CU-868f7hkrj Fixing CallKit dependency #160
Conversation
WalkthroughAdded the CallKeep Expo config plugin to app.config.ts and updated dependencies in package.json by adding @config-plugins/react-native-callkeep and pointing react-native-callkeep to a GitHub repository URL. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
app.config.ts (1)
263-263: Verify Android 14+ permission and plugin orderingPlease manually confirm the following:
- After running
expo prebuild, openandroid/app/src/main/AndroidManifest.xmland verify that it contains
<uses-permission android:name="android.permission.FOREGROUND_SERVICE_PHONE_CALL"/>.
If it’s missing, add'android.permission.FOREGROUND_SERVICE_PHONE_CALL'to theandroid.permissionsarray in yourapp.config.ts.- In
app.config.ts, ensure that
'@config-plugins/react-native-callkeep'
appears before yourcustomManifest.plugin.jsentry in thepluginsarray, so your PhoneAccount/ConnectionService tweaks aren’t overridden.Suggested check after prebuild:
rg -nA2 'FOREGROUND_SERVICE_PHONE_CALL' android/app/src/main/AndroidManifest.xmlpackage.json (1)
49-49: Use tilde (~) instead of caret (^) to minimize config plugin breakageMost Expo config plugins are sensitive to minor changes. To reduce accidental config drift during CI/CD, prefer ~11.0.0 over ^11.0.0 for @config-plugins/react-native-callkeep (consistent with how you pin @config-plugins/react-native-webrtc).
Apply:
- "@config-plugins/react-native-callkeep": "^11.0.0", + "@config-plugins/react-native-callkeep": "~11.0.0",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (2)
app.config.ts(1 hunks)package.json(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{ts,tsx}
📄 CodeRabbit Inference Engine (.cursorrules)
**/*.{ts,tsx}: Write concise, type-safe TypeScript code
Use camelCase for variable and function names (e.g., isFetchingData, handleUserInput)
Use TypeScript for all components, favoring interfaces for props and state
Avoid using any; strive for precise types
Use Expo SecureStore for sensitive data
Use zustand for state management
Use react-query for data fetching and caching
Use react-i18next for internationalization
Use react-native-mmkv for local storage
Use axios for API requests
**/*.{ts,tsx}: Write concise, type-safe TypeScript code
Use camelCase for variable and function names
Use TypeScript for all components, favoring interfaces for props and state
Avoid using any; strive for precise types
Use React Navigation for handling navigation and deep linking
Handle errors gracefully and provide user feedback
Use Expo's SecureStore for sensitive data
Use zustand for state management
Use react-query for data fetching
Use react-i18next for internationalization
Use react-native-mmkv for local storage
Use axios for API requests
Files:
app.config.ts
**/*
📄 CodeRabbit Inference Engine (.cursorrules)
Directory and file names should be lowercase and hyphenated (e.g., user-profile, chat-screen)
Files:
app.config.tspackage.json
| "react-native-base64": "~0.2.1", | ||
| "react-native-ble-manager": "^12.1.5", | ||
| "react-native-callkeep": "^4.3.16", | ||
| "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep", |
There was a problem hiding this comment.
💡 Verification agent
🧩 Analysis chain
Pin the GitHub dependency to a commit/tag for reproducible builds
Using a moving GitHub branch URL can produce non-deterministic installs and surprise build failures. Pin to a specific commit or tag.
Example (replace with the exact commit you need):
- "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
+ "react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>",Also, briefly document in the PR description or a comment why the fork is required and which upstream issue/PR it addresses (helps future maintainers).
To confirm what you’re installing, run:
🏁 Script executed:
#!/bin/bash
# Shows the resolved URL for the dependency after install (run locally where node_modules is present)
node -e "const p=require('./package.json'); console.log(p.dependencies['react-native-callkeep'])"Length of output: 162
Pin GitHub dependency to a specific commit for reproducible installs
Using a floating URL for react-native-callkeep can lead to non-deterministic installs and unexpected breakages when the remote branch advances. Please update your dependency to point at a specific commit or tag, and document why you’re using this fork (e.g. which upstream issue or PR it addresses).
• File: package.json (line 148)
• Replace:
- "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
+ "react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>",• In your PR description (or here in a comment), note:
– The reason this fork is needed
– Which upstream issue/PR it fixes
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep", | |
| "react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>", |
🤖 Prompt for AI Agents
In package.json around line 148, the dependency "react-native-callkeep" is
pointing to a floating GitHub branch URL which makes installs non-deterministic;
update the value to reference a specific commit SHA or a tag (e.g.
"https://github.com/Irfanwani/react-native-callkeep.git#<commit-sha>") to pin
the dependency, run npm/yarn install to verify, and update the PR description to
explain why this fork is used and which upstream issue/PR it addresses (include
link and short rationale).
|
Approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Summary by CodeRabbit
New Features
Chores