Skip to content

CU-868f7hkrj Fixing CallKit dependency #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucswift merged 1 commit into from
Aug 17, 2025
Merged

CU-868f7hkrj Fixing CallKit dependency #160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ export default ({ config }: ConfigContext): ExpoConfig => ({
'react-native-ble-manager',
'@livekit/react-native-expo-plugin',
'@config-plugins/react-native-webrtc',
'@config-plugins/react-native-callkeep',
'./customGradle.plugin.js',
'./customManifest.plugin.js',
['app-icon-badge', appIconBadgeConfig],
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
},
"dependencies": {
"@aptabase/react-native": "^0.3.10",
"@config-plugins/react-native-callkeep": "^11.0.0",
"@config-plugins/react-native-webrtc": "~12.0.0",
"@dev-plugins/react-query": "~0.2.0",
"@expo/config-plugins": "~9.0.0",
Expand Down Expand Up @@ -144,7 +145,7 @@
"react-native": "0.76.9",
"react-native-base64": "~0.2.1",
"react-native-ble-manager": "^12.1.5",
"react-native-callkeep": "^4.3.16",
"react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
Copy link

@coderabbitai coderabbitai bot Aug 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Pin the GitHub dependency to a commit/tag for reproducible builds

Using a moving GitHub branch URL can produce non-deterministic installs and surprise build failures. Pin to a specific commit or tag.

Example (replace with the exact commit you need):

-    "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
+    "react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>",

Also, briefly document in the PR description or a comment why the fork is required and which upstream issue/PR it addresses (helps future maintainers).

To confirm what you’re installing, run:

🏁 Script executed:

#!/bin/bash
# Shows the resolved URL for the dependency after install (run locally where node_modules is present)
node -e "const p=require('./package.json'); console.log(p.dependencies['react-native-callkeep'])"

Length of output: 162

Pin GitHub dependency to a specific commit for reproducible installs

Using a floating URL for react-native-callkeep can lead to non-deterministic installs and unexpected breakages when the remote branch advances. Please update your dependency to point at a specific commit or tag, and document why you’re using this fork (e.g. which upstream issue or PR it addresses).

• File: package.json (line 148)
• Replace:

-  "react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
+  "react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>",

• In your PR description (or here in a comment), note:
– The reason this fork is needed
– Which upstream issue/PR it fixes

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"react-native-callkeep": "https://github.com/Irfanwani/react-native-callkeep",
"react-native-callkeep": "github:Irfanwani/react-native-callkeep#<commit-sha>",
🤖 Prompt for AI Agents 
In package.json around line 148, the dependency "react-native-callkeep" is
pointing to a floating GitHub branch URL which makes installs non-deterministic;
update the value to reference a specific commit SHA or a tag (e.g.
"https://github.com/Irfanwani/react-native-callkeep.git#<commit-sha>") to pin
the dependency, run npm/yarn install to verify, and update the PR description to
explain why this fork is used and which upstream issue/PR it addresses (include
link and short rationale).

"react-native-edge-to-edge": "~1.1.2",
"react-native-flash-message": "~0.4.2",
"react-native-gesture-handler": "~2.20.2",
Expand Down
10 changes: 7 additions & 3 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1032,6 +1032,11 @@
"@types/conventional-commits-parser" "^5.0.0"
chalk "^5.3.0"

"@config-plugins/react-native-callkeep@^11.0.0":
version "11.0.0"
resolved "https://registry.yarnpkg.com/@config-plugins/react-native-callkeep/-/react-native-callkeep-11.0.0.tgz#d97526bb7cebc3082701fd6b3c285a56479a0a66"
integrity sha512-DsfpNU+VCgF9/fNU/BHxlJa1+RiMz0UpFDp4Yj86hk0uahA5sPHmMIThhMg4DJjdYL70U6wELSzsGYaAcsI4vQ==

"@config-plugins/react-native-webrtc@~12.0.0":
version "12.0.0"
resolved "https://registry.yarnpkg.com/@config-plugins/react-native-webrtc/-/react-native-webrtc-12.0.0.tgz#2bad8d59fa8aeb1b311c82c8704259154b00805f"
Expand Down Expand Up @@ -12451,10 +12456,9 @@ react-native-ble-manager@^12.1.5:
resolved "https://registry.yarnpkg.com/react-native-ble-manager/-/react-native-ble-manager-12.1.5.tgz#84d3a521c1e51eb0a30f1bbb0c00c3930b62b00a"
integrity sha512-kTt2nYBnouyOyw9TN37dDuUAdhtcg1pduF+XSRCBXoBEWp6F5u4P16ISoo25rpc19R9dE2hSovoMSDwwwCaWsw==

react-native-callkeep@^4.3.16:
"react-native-callkeep@https://github.com/Irfanwani/react-native-callkeep":
version "4.3.16"
resolved "https://registry.yarnpkg.com/react-native-callkeep/-/react-native-callkeep-4.3.16.tgz#56291796984b896113ef00f8b67ae3fe177baf70"
integrity sha512-aIxn02T5zW4jNPyzRdFGTWv6xD3Vy/1AkBMB6iYvWZEHWnfmgNGF0hELqg03Vbc2BNUhfqpu17aIydos+5Hurg==
resolved "https://github.com/Irfanwani/react-native-callkeep#957193d0716f1c2dfdc18e627cbff0f8a0800971"

[email protected]:
version "0.1.22"
Expand Down
Loading