Make all game speeds available to "v" key #1829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Introduce constants for the speed and speed steps, assert the min and max are reachable and adapt conditions for step size and minimal/maximal step to debug speeds. Closes Return-To-The-Roots#1828
Flow86
reviewed
Nov 17, 2025
Flow86
approved these changes
Nov 19, 2025
Member
Author
|
Could you fix Jenkins and rerun the builds please? |
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 26, 2025
Fixes Return-To-The-Roots#1828 after regression in Return-To-The-Roots#1829
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 26, 2025
Fixes Return-To-The-Roots#1828 after regression in Return-To-The-Roots#1829
Flamefire
added a commit
to Flamefire/s25client
that referenced
this pull request
Dec 26, 2025
Fixes Return-To-The-Roots#1828 after regression in Return-To-The-Roots#1829
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce constants for the speed and speed steps, assert the min and max are reachable
and adapt conditions for step size and minimal/maximal step to debug speeds.
Closes #1828