Fix shortcuts using SDL2 and ALT+Q using WinAPI #1831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We usually need either a KeyType event with everything else zero/false, or a char event with some modifiers. Especially the latter causes a list of consecutive bool params, where an explicit set is more readable.
ALT+q or CTRL+z do not produce text input. ALT+0054 does produce a single char. However ALT or CTRL and a letter do not produce combined chars. So use that to trigger input events. Fixes Return-To-The-Roots#1583
Flow86
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1583
WinAPI won't emit set the ALT key-pressed member because it needs to check the HIWORD of
lparamforKF_ALTDOWNSDL2 uses only TEXTINPUT events for keydown of letters.
So use 1. & 3. to trigger input events without duplicate input from TEXTINPUT.