Skip to content

Conversation

@ericdow
Copy link
Contributor

@ericdow ericdow commented Jan 9, 2025

Changes

Since the various ApplyImpulse functions apply a "pure" impulse (resulting in an instantaneous change in velocity), using the word "force" is misleading. A force must be applied over some finite time span to produce a velocity change, whereas an impulse is applied instantaneously. This has led to confusion among developers.

Checks

By submitting your pull request for review, you agree to the following:

  • This contribution was created in whole or in part by me, and I have the right to submit it under the terms of this repository's open source licenses.
  • I understand and agree that this contribution and a record of it are public, maintained indefinitely, and may be redistributed under the terms of this repository's open source licenses.
  • To the best of my knowledge, all proposed changes are accurate.

Since the various ApplyImpulse functions apply a "pure" impulse (resulting in an instantaneous change in velocity), using the word "force" is misleading. A force must be applied over some finite time span to produce a velocity change, whereas an impulse is applied instantaneously. This has led to confusion among developers.
@ericdow ericdow requested a review from a team as a code owner January 9, 2025 19:57
@github-actions github-actions bot added the engine reference Changes the Engine API Reference documentation label Jan 9, 2025
Copy link

@PrinceTybalt PrinceTybalt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for this

@ericdow ericdow merged commit 28703e7 into main Jan 10, 2025
3 checks passed
@ericdow ericdow deleted the ericdow-patch-1 branch January 10, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine reference Changes the Engine API Reference documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants