Allow specifying POINT_TYPE as cmake option#207
Open
CyrillePierre wants to merge 1 commit intoRoboSense-LiDAR:mainfrom
Open
Allow specifying POINT_TYPE as cmake option#207CyrillePierre wants to merge 1 commit intoRoboSense-LiDAR:mainfrom
CyrillePierre wants to merge 1 commit intoRoboSense-LiDAR:mainfrom
Conversation
|
I have a repo that integrates PRs from this official repo: https://github.com/jfrascon/rslidar_sdk |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, in the
CMakeLists.txt, thePOINT_TYPEis defined usingAs explained in the documentation, to change its value, the user have to edit this file.
I believe that users should not have to edit any project file just to choose a particular configuration. This would requires them to create a fork of the project to maintain their changes.
Instead, I propose to let the user select the
POINT_TYPEin a similar way than other options likeENABLE_DIFOP_PARSEorENABLE_IMU_DATA_PARSE. It is still possible to edit the CMakeLists.txt, but this PR allows to specify thePOINT_TYPEfrom the command line. For example, in ROS2 with colcon:To summarize, I changed the following things:
POINT_TYPEis already defined in theCMakeLists.txtHowever, I do not speak Chinese, so I do not have edited this version of the documentation.