Add missing functions for timer #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing timer functions and corresponding tests to supplement the timer API.
- Added tests in test-timer.js for timerPeriod, changeTimerPeriod, and callTimerWithInfo.
- Extended native bindings in src/rcl_timer_bindings.cpp to support new timer functions.
- Updated the Timer class in lib/timer.js to expose changeTimerPeriod, timerPeriod getter, and callTimerWithInfo methods.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/test-timer.js | Introduces tests for the new timer functions to verify their behavior. |
| src/rcl_timer_bindings.cpp | Implements the native bindings for changing and retrieving timer period and call info. |
| lib/timer.js | Exposes newly added timer functions through the Timer class API. |
Comments suppressed due to low confidence (1)
src/rcl_timer_bindings.cpp:209
- The property name 'expectetCallTime' is misspelled; consider renaming it to 'expectedCallTime' for clarity and consistency.
timer_info.Set("expectetCallTime", Napi::BigInt::New(env, call_info.expected_call_time));
test/test-timer.js
Outdated
| it('timer.callTimerWithInfo', function (done) { | ||
| const timer = node.createTimer(BigInt('100000000'), () => {}); | ||
| const info = timer.callTimerWithInfo(); | ||
| assert.deepStrictEqual(typeof info.expectetCallTime, 'bigint'); |
There was a problem hiding this comment.
There is a spelling mistake in the property name 'expectetCallTime'; it should be 'expectedCallTime'.
Suggested change
| assert.deepStrictEqual(typeof info.expectetCallTime, 'bigint'); | |
| assert.deepStrictEqual(typeof info.expectedCallTime, 'bigint'); |
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing timer functionalities and their corresponding unit tests. The key changes include:
- New unit tests for timer operations in test/test-timer.js.
- New timer binding functions in src/rcl_timer_bindings.cpp to support period retrieval, timer period change, and timer call information.
- New Timer class methods and getter in lib/timer.js to expose the newly added timer functionalities.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/test-timer.js | Added tests for timerPeriod, changeTimerPeriod, and callTimerWithInfo |
| src/rcl_timer_bindings.cpp | Added native bindings for timer period manipulation and info retrieval |
| lib/timer.js | Introduced Timer methods for period change, retrieval, and call with info |
minggangw
added a commit
that referenced
this pull request
Apr 30, 2025
This PR adds missing timer functionalities and their corresponding unit tests. The key changes include: - New unit tests for timer operations in test/test-timer.js. - New timer binding functions in src/rcl_timer_bindings.cpp to support period retrieval, timer period change, and timer call information. - New Timer class methods and getter in lib/timer.js to expose the newly added timer functionalities. Fix: #1109
minggangw
added a commit
that referenced
this pull request
Apr 30, 2025
minggangw
added a commit
that referenced
this pull request
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds missing timer functionalities and their corresponding unit tests. The key changes include:
Fix: #1109