Fix example errors #1205
Merged
Fix example errors #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes timing and property access errors in example code. The changes correct a timer interval misconfiguration and fix incorrect property access in action client feedback handling.
- Fixed timer interval from 1 millisecond to 1 second (1 billion nanoseconds)
- Corrected feedback message property access by removing redundant
.feedbackaccessor
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| example/timer/timer-example.js | Corrected timer interval from 1ms to 1s to match the console log message |
| example/actions/action_client/action-client-cancel-example.js | Fixed feedback message property access by removing incorrect .feedback level |
minggangw
added a commit
that referenced
this pull request
Jul 22, 2025
This PR fixes timing and property access errors in example code. The changes correct a timer interval misconfiguration and fix incorrect property access in action client feedback handling. - Fixed timer interval from 1 millisecond to 1 second (1 billion nanoseconds) - Corrected feedback message property access by removing redundant `.feedback` accessor Fix: #1204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes timing and property access errors in example code. The changes correct a timer interval misconfiguration and fix incorrect property access in action client feedback handling.
.feedbackaccessorFix: #1204