Correct exmple errors #1208
Merged
Correct exmple errors #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes errors in two example files related to ROSIDL parsing and action server functionality. The changes address missing module imports and improve code clarity with better numeric formatting.
- Adds missing parser module import in the ROSIDL parse action example
- Updates timer interval from BigInt constructor to BigInt literal notation with explanatory comment
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| example/rosidl/rosidl-parse-action-example.js | Adds missing import for the rosidl_parser module |
| example/actions/action_server/action-server-defer-example.js | Updates BigInt syntax and adds clarifying comment for timer interval |
| this._node.getLogger().info('Deferring execution...'); | ||
| this._goalHandle = goalHandle; | ||
| this._timer = this._node.createTimer(BigInt(3000000), () => | ||
| // Set timeout period to 3s. |
There was a problem hiding this comment.
The comment states '3s' but the BigInt value 3000000000n represents 3 billion nanoseconds (3 seconds). Consider making this relationship clearer in the comment, e.g., '// Set timeout period to 3s (3 billion nanoseconds).'
Suggested change
| // Set timeout period to 3s. | |
| // Set timeout period to 3s (3 billion nanoseconds). |
minggangw
added a commit
that referenced
this pull request
Jul 25, 2025
This PR fixes errors in two example files related to ROSIDL parsing and action server functionality. The changes address missing module imports and improve code clarity with better numeric formatting. - Adds missing parser module import in the ROSIDL parse action example - Updates timer interval from BigInt constructor to BigInt literal notation with explanatory comment Fix: #1207
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes errors in two example files related to ROSIDL parsing and action server functionality. The changes address missing module imports and improve code clarity with better numeric formatting.
Fix: #1207