Skip to content

Correct exmple errors #1208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2025
Merged

Correct exmple errors #1208

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6e44b7
Correct exmple errors
minggangw Jul 23, 2025
7a563f9
Address comments
minggangw Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion example/actions/action_server/action-server-defer-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ class FibonacciActionServer {
handleAcceptedCallback(goalHandle) {
this._node.getLogger().info('Deferring execution...');
this._goalHandle = goalHandle;
this._timer = this._node.createTimer(BigInt(3000000), () =>
// Set timeout period to 3s.
Copy link

Copilot AI Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment states '3s' but the BigInt value 3000000000n represents 3 billion nanoseconds (3 seconds). Consider making this relationship clearer in the comment, e.g., '// Set timeout period to 3s (3 billion nanoseconds).'

Suggested change
// Set timeout period to 3s.
// Set timeout period to 3s (3 billion nanoseconds).

Copilot uses AI. Check for mistakes.
this._timer = this._node.createTimer(3000000000n, () =>
this.timerCallback()
);
}
Expand Down
1 change: 1 addition & 0 deletions example/rosidl/rosidl-parse-action-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
const rosInstallPath = process.env.AMENT_PREFIX_PATH;
const packageName = 'test_msgs';
const packagePath = rosInstallPath + '/share/test_msgs/action/Fibonacci.action';
const parser = require('../../rosidl_parser/rosidl_parser.js');

parser
.parseActionFile(packageName, packagePath)
Expand Down
Loading