Skip to content

Conversation

@minggangw
Copy link
Member

@minggangw minggangw commented Sep 2, 2025

This PR separates GitHub Actions workflows to handle push and pull request events separately, improving CI/CD organization and allowing for different behaviors based on trigger type.

  • Converted existing combined workflows into reusable workflows that accept a trigger_type parameter
  • Created separate PR and push-specific workflows for each platform (Linux x64, Linux ARM64, Windows)
  • Updated README badges to reference the new push-specific workflow files

Fix: #1250

Copilot AI review requested due to automatic review settings September 2, 2025 07:03
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR separates GitHub Actions workflows to handle push and pull request events separately, improving CI/CD organization and allowing for different behaviors based on trigger type.

  • Converted existing combined workflows into reusable workflows that accept a trigger_type parameter
  • Created separate PR and push-specific workflows for each platform (Linux x64, Linux ARM64, Windows)
  • Updated README badges to reference the new push-specific workflow files

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
README.md Updated workflow badge URLs to reference new push-specific workflow files
.github/workflows/windows-push-test.yml New workflow for Windows push events
.github/workflows/windows-pr-test.yml New workflow for Windows pull request events
.github/workflows/windows-build-and-test.yml Converted to reusable workflow with trigger_type input
.github/workflows/windows-build-and-test-compatibility.yml Removed compatibility test workflow
.github/workflows/linux-x64-push-test.yml New workflow for Linux x64 push events
.github/workflows/linux-x64-pr-test.yml New workflow for Linux x64 pull request events
.github/workflows/linux-x64-build-and-test.yml Converted to reusable workflow with trigger_type input
.github/workflows/linux-build-and-test-compatibility.yml Removed compatibility test workflow
.github/workflows/linux-arm64-push-test.yml New workflow for Linux ARM64 push events
.github/workflows/linux-arm64-pr-test.yml New workflow for Linux ARM64 pull request events
.github/workflows/linux-arm64-build-and-test.yml Converted to reusable workflow with trigger_type input

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@coveralls
Copy link

coveralls commented Sep 2, 2025

Coverage Status

coverage: 84.366% (-0.2%) from 84.555%
when pulling 868b180 on minggangw:fix-1250
into 9c2558c on RobotWebTools:develop.

@minggangw minggangw merged commit fa17348 into RobotWebTools:develop Sep 2, 2025
26 of 27 checks passed
minggangw added a commit that referenced this pull request Sep 10, 2025
This PR separates GitHub Actions workflows to handle push and pull request events separately, improving CI/CD organization and allowing for different behaviors based on trigger type.

- Converted existing combined workflows into reusable workflows that accept a trigger_type parameter
- Created separate PR and push-specific workflows for each platform (Linux x64, Linux ARM64, Windows)
- Updated README badges to reference the new push-specific workflow files

Fix: #1250
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split current actions into targeting on PR/PUSH separately

2 participants