Skip to content

Fix randomly failing subscribe unsubscribe test#1008

Merged
bjsowa merged 1 commit intoros2from
fix/subscribe-unsubscribe-test
Feb 12, 2025
Merged

Fix randomly failing subscribe unsubscribe test#1008
bjsowa merged 1 commit intoros2from
fix/subscribe-unsubscribe-test

Conversation

@bjsowa
Copy link
Member

@bjsowa bjsowa commented Feb 12, 2025

This test keeps randomly failing in Github actions and it's starting to drive me nuts

@bjsowa bjsowa marked this pull request as draft February 12, 2025 16:30
@bjsowa bjsowa marked this pull request as ready for review February 12, 2025 18:03
@bjsowa
Copy link
Member Author

bjsowa commented Feb 12, 2025

I've run the workflow 10 times and it didn't fail a single time now.

@bjsowa bjsowa requested a review from sea-bass February 12, 2025 18:03
@bjsowa bjsowa merged commit f5953a8 into ros2 Feb 12, 2025
6 checks passed
@bjsowa bjsowa deleted the fix/subscribe-unsubscribe-test branch February 12, 2025 18:13
bjsowa added a commit that referenced this pull request Feb 26, 2025
Add a delay before asserting topic is unsubscribed in unsubscribe test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants