fix: Handle action rejection and server timeout#1139
Merged
bjsowa merged 7 commits intoRobotWebTools:ros2from Feb 22, 2026
Merged
fix: Handle action rejection and server timeout#1139bjsowa merged 7 commits intoRobotWebTools:ros2from
bjsowa merged 7 commits intoRobotWebTools:ros2from
Conversation
The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal
bjsowa
approved these changes
Feb 22, 2026
bjsowa
changed the title
bjsowa
added a commit
that referenced
this pull request
Feb 22, 2026
* add server timeout exception * forward rejected goal handles The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal * return an empty result when result was None due to cancellation/abortion * fix lint error --------- Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
bjsowa
added a commit
that referenced
this pull request
Feb 22, 2026
* add server timeout exception * forward rejected goal handles The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal * return an empty result when result was None due to cancellation/abortion * fix lint error --------- Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
bjsowa
added a commit
that referenced
this pull request
Feb 22, 2026
* add server timeout exception * forward rejected goal handles The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal * return an empty result when result was None due to cancellation/abortion * fix lint error --------- Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
bjsowa
added a commit
that referenced
this pull request
Feb 22, 2026
* add server timeout exception * forward rejected goal handles The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal * return an empty result when result was None due to cancellation/abortion * fix lint error --------- Co-authored-by: Błażej Sowa <bsowa123@gmail.com>
bjsowa
added a commit
that referenced
this pull request
Feb 22, 2026
* add server timeout exception * forward rejected goal handles The goal_response_cb should not throw an exception, so the exception is passed in the result and then raised in send_goal * return an empty result when result was None due to cancellation/abortion * fix lint error --------- Co-authored-by: Spir0u <28966599+Spir0u@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
Actions forward an error when not available/they get cancelled
Description