Add option to define per-topic QoS settings at startup#1149
Open
rasmusan wants to merge 2 commits intoRobotWebTools:ros2from
Open
Add option to define per-topic QoS settings at startup#1149rasmusan wants to merge 2 commits intoRobotWebTools:ros2from
rasmusan wants to merge 2 commits intoRobotWebTools:ros2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Allows user to provide a qos settings file of the form:
Subscriptions created by the bridge will use these QoS settings, no matter what topics exist. This can be used to prevent race conditions where QoS settings are inherited from topics that may or may not exist at time of startup.
Related to #887 (although the idea is different).