fix: max message size not included in tornado settings.#1160
Open
ikwilnaarhuisman wants to merge 2 commits intoRobotWebTools:ros2from
Open
fix: max message size not included in tornado settings.#1160ikwilnaarhuisman wants to merge 2 commits intoRobotWebTools:ros2from
ikwilnaarhuisman wants to merge 2 commits intoRobotWebTools:ros2from
Conversation
Member
|
It would be helpful to add a test to rosbridge_server which tests this behavior so this does not happen in the future. Could you write one? |
Author
|
I had a look at implementing a unit test where you could assert the max_message_size with the tornado max_message_size, but because tornado doesn't expose its parameters at runtime. I can't access it. I'm not sure how to unit test it without adding extra functionality. |
Author
|
Please note that when tornado receives messages bigger than the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The max message size used to be implicitly used by the tornado settings, but this was broken in commit 949d7c3.
Because what used to happen is that the tornado.web.Application could implicitly find the attribute about the max_message_size, but because this was moved to a dictionary it can no longer. Causing Tornado to automatically disconnect when it receives a message exceeding 10 megabytes.
@YannickdeHoop