Call services and send action goals in new threads by default#996
Merged
Call services and send action goals in new threads by default#996
Conversation
sea-bass
reviewed
Jan 23, 2025
Contributor
sea-bass
left a comment
sea-bass
left a comment
There was a problem hiding this comment.
Good idea. Can you do the same for the actions parameter?
sea-bass
approved these changes
Jan 23, 2025
Contributor
sea-bass
left a comment
sea-bass
left a comment
There was a problem hiding this comment.
Thanks! Just rename the PR title to include them both and LGTM
bjsowa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Public API Changes
None
Description
Since we've already made some breaking changes for Jazzy, I would also like to change the default value of
call_services_in_new_threadparameter to true. IMO it gives better out-of-box experience.