-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore: upgrade to react native 81 and expo 54 #6875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Rohit3523
wants to merge
196
commits into
develop
Choose a base branch
from
react-native-81
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 193 commits
Commits
Show all changes
196 commits
Select commit
Hold shift + click to select a range
f58a536
reanimated v4 and worklets
Rohit3523 23ec327
some alignment
Rohit3523 abab68f
remove unused
Rohit3523 1514c7e
runOnJs is now scheduleOnRN
Rohit3523 5f28192
jest update
Rohit3523 c0a4d25
chore: format code with Prettier [skip ci]
Rohit3523 f27e9f5
let me trigger ci
Rohit3523 14ecf41
revert
Rohit3523 58b5141
Using gorhom bottomsheet
Rohit3523 a624049
jest and test changes
Rohit3523 00af6b8
remove patch
Rohit3523 d181c65
fix type
Rohit3523 d3f516b
fix import, idk why they did this
Rohit3523 b2c221d
Project upgrade
Rohit3523 5e48723
added worklet, more package upgrade and ios changes
Rohit3523 261b939
react native patch for installing pod
Rohit3523 b64c1eb
downgrade typescript
Rohit3523 e1eaf31
extend tsconfig for react native
Rohit3523 1998f31
patch changes
Rohit3523 7e7f3d0
chore: format code and fix lint issues [skip ci]
Rohit3523 64a72f6
Remove ts extends
Rohit3523 998504c
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 691fb63
metro config fix
Rohit3523 caedf9e
Merge remote-tracking branch 'upstream/develop' into reanimated-v4
Rohit3523 cbfe560
lint fix
Rohit3523 8f89ea2
chore: format code and fix lint issues [skip ci]
Rohit3523 65be6cf
feat: basic setup react-native-true-sheet
OtavioStasiak 08056fb
fix: scroll height
OtavioStasiak b4a596f
fix: inconsistentaction sheet openning
OtavioStasiak 76cc834
feat: add min height
OtavioStasiak e13c5a4
revert the bottom sheet changes
Rohit3523 4fe2c97
revert version
Rohit3523 64f4dd9
Merge branch 'develop' into reanimated-v4
Rohit3523 1dba726
lock fix
Rohit3523 caf9d5a
chore: format code and fix lint issues
Rohit3523 b0d5d9f
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak e3ccc64
chore: use Touch instead of pressable
OtavioStasiak 2f535e3
cleanup
OtavioStasiak 3776737
fix: padding on list and custom actionSheet content
OtavioStasiak 7f04181
fix: actionsheet + gesture handler compatibility
OtavioStasiak 40d9fb9
rollback Pressable
OtavioStasiak f868d6d
fix: pressable emoji
OtavioStasiak 504d378
chore: comment
OtavioStasiak 54698cb
fix: action sheet custom content height
OtavioStasiak 9ed2a82
fix: directory test
OtavioStasiak baca611
fix: emoji picker
OtavioStasiak fd97518
fix: close action sheet
OtavioStasiak deb038d
fix: bottom sheet emoji picker scroll and padding
OtavioStasiak 6afa789
chore: format code and fix lint issues
OtavioStasiak 3937eec
fix: bottomSheet iOS weird padding
OtavioStasiak acd8675
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak 854b508
fix: add sleep to pass tests
OtavioStasiak 9feee82
fix: e2e tests
OtavioStasiak b5aaff9
Merge branch 'develop' into reanimated-v4
Rohit3523 6413650
conflict fix
Rohit3523 d0f3d39
Merge branch 'develop' into reanimated-v4
Rohit3523 a8cdebd
Move worklet plugin to last
Rohit3523 ebe4419
Merge branch 'reanimated-v4' of https://github.com/RocketChat/Rocket.…
Rohit3523 b054ed4
fix: roomView test
OtavioStasiak bcbc7fe
fix: e2e tests
OtavioStasiak 8a0d12c
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak 02cd74f
fix: code improvements
OtavioStasiak e50f3ad
fix: update required height
OtavioStasiak af3098d
Update patches/@lodev09+react-native-true-sheet+3.7.3.patch
OtavioStasiak b7c2b2f
code improvements
OtavioStasiak 22ff512
fix: style
OtavioStasiak cc271ef
chore: format code and fix lint issues
OtavioStasiak eb37e68
remove unused style
OtavioStasiak b5a87b7
clean patch package
OtavioStasiak a0a6854
fix: remove border rounded and fixing padding issues
OtavioStasiak ebd8f88
fix: list padding
OtavioStasiak f4defa6
adjust bottom padding
OtavioStasiak d66c812
fix: android Directory view Actionsheet click and Servers List render
OtavioStasiak 7662c7f
fix: orientation and unit test
OtavioStasiak 88e8b42
Merge branch 'develop' into test.poc-a11y-bottom-shet
OtavioStasiak c19cadf
chore: format code and fix lint issues
OtavioStasiak 7946eb4
fix: remve highlight of handle
OtavioStasiak d6a3237
cleanup
OtavioStasiak 6fc21de
more bottom sheet changes
Rohit3523 7d1f242
adjustment for android
Rohit3523 301b0c3
chore: format code and fix lint issues
Rohit3523 8daab95
rerun
Rohit3523 d23a7e0
revert
Rohit3523 7c02045
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 38cd2c9
test update
Rohit3523 930c88a
some improvements
Rohit3523 d0d218b
fix test
Rohit3523 3bab462
test fix
Rohit3523 cd35041
Remove unused bottomSheet prop
Rohit3523 35b55df
memorise bottom sheet handle
Rohit3523 50e1ffc
remove unused import
Rohit3523 ec14b28
ios test fix
Rohit3523 28d9062
clear timeout
Rohit3523 fb40b8b
wait for animation to close
Rohit3523 ae5df9f
Merge branch 'develop' into test.poc-a11y-bottom-shet
Rohit3523 fdaf544
lint fix
Rohit3523 05c7b5a
chore: format code and fix lint issues
Rohit3523 5064359
add comment for extra style
Rohit3523 650104e
tap on point to hide sheet
Rohit3523 7144138
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 8db5f90
suggested changes by copilot and copilot
Rohit3523 d3f23e7
chore: format code and fix lint issues
Rohit3523 c03938c
revert the test
Rohit3523 4e7cc2b
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 0e45349
Change sheet min height
Rohit3523 dbffe97
disable content panning for android
Rohit3523 d33a796
chore: format code and fix lint issues
Rohit3523 719c192
rerun
Rohit3523 1e6da08
revert
Rohit3523 e8abcf1
test update
Rohit3523 8b410dc
correct cancel button height
Rohit3523 b81a3ae
Remove timeout to present sheet
Rohit3523 4a7a9fb
Merge branch 'develop' into react-native-81
Rohit3523 709d7d8
chore: format code and fix lint issues
Rohit3523 9e60c47
Remove space
Rohit3523 449360a
ios fix
Rohit3523 9b1713c
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 3dc77ca
package align
Rohit3523 9c25b88
Added bottom sheet in dev because of storybook
Rohit3523 9ff7576
snap update
Rohit3523 28d8d4e
Test fix
Rohit3523 1ddf1c6
test fix
Rohit3523 54c2e9d
Merge branch 'develop' into reanimated-v4
Rohit3523 a367e02
chore: format code and fix lint issues
Rohit3523 2b3e51a
lock file fixed
Rohit3523 5756896
Merge branch 'develop' into test.poc-a11y-bottom-shet
Rohit3523 45d1292
increase reaction open time
Rohit3523 ac20a76
Merge branch 'test.poc-a11y-bottom-shet' of https://github.com/Rocket…
Rohit3523 cdda960
increase timeout
Rohit3523 cf08b03
Upgrade to RN 0.81.6
Rohit3523 cff02b6
Removed deprecated addWhitelistedNativeProps
Rohit3523 c48a040
Merge branch 'test.poc-a11y-bottom-shet' into reanimated-v4
Rohit3523 175bd53
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 1d7d89d
revert to rn 0.81.5
Rohit3523 bf5c915
snap update
Rohit3523 5042da6
remove worklet from jest
Rohit3523 912278c
Replace thumb button with touch
Rohit3523 2f1ba4a
update expo-file-system import to legacy
Rohit3523 59cae3a
ts fix
Rohit3523 1529a23
patch for webview
Rohit3523 4ed67ee
remove rn web 13.15.0 patch
Rohit3523 0232059
use custom snapshot serializer
Rohit3523 01552c7
snapshot update
Rohit3523 a603042
chore: format code and fix lint issues
Rohit3523 e9590e3
prettier ;-;
Rohit3523 063ce88
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 f80ab8e
pod update
Rohit3523 53d9751
fix for expo-file-system in android
Rohit3523 cdf85b0
Merge branch 'develop' into reanimated-v4
Rohit3523 4ff6637
pod update
Rohit3523 c2a6ca4
Merge branch 'develop' into react-native-81
Rohit3523 31d5e63
lock file fix
Rohit3523 cfc5f2e
enable liquid glass ui
Rohit3523 2116a2d
list item are not accessible for e2e, so maestro can interact with sw…
Rohit3523 c8a5cce
chore: format code and fix lint issues
Rohit3523 291143b
Merge branch 'develop' into react-native-81
Rohit3523 bdf46e7
Merge branch 'develop' into react-native-81
Rohit3523 21f08c8
revert last change
Rohit3523 fd24f10
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 8048a08
improve logic...
Rohit3523 fbe735c
A temp change
Rohit3523 05cacf5
use rect button
Rohit3523 be81a47
test update
Rohit3523 f3c0d50
use match like in accessibility test
Rohit3523 6929797
ios profile test fix
Rohit3523 d327896
test fix
Rohit3523 09d63d8
Added test id in directory
Rohit3523 951558d
chore: format code and fix lint issues
Rohit3523 b4cd9b5
path fix ;-;
Rohit3523 ee7133d
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 7f5e04d
coderabbit suggestion
Rohit3523 88be3cd
coderabbit suggestion
Rohit3523 6bb597e
Merge branch 'develop' into reanimated-v4
Rohit3523 03e0ae0
seekbar improvement
Rohit3523 a130cd1
Replace more runOnJS to scheduleOnRN
Rohit3523 a541660
Merge branch 'reanimated-v4' of https://github.com/RocketChat/Rocket.…
Rohit3523 6e35a0b
update seekbar
Rohit3523 49eb0d8
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 6d0ef3a
trying to use RectButton in handle
Rohit3523 4688922
chore: format code and fix lint issues
Rohit3523 857ea2c
using TouchableNativeFeedback from RNGH
Rohit3523 8f9b788
readded message parser patch ;-;
Rohit3523 5646bdf
Merge branch 'react-native-81' of https://github.com/RocketChat/Rocke…
Rohit3523 9ca79ca
Switch from TouchableNativeFeedback to TouchableHighlight ;-;
Rohit3523 d169c97
chore: format code and fix lint issues
Rohit3523 0125108
rerun ci
Rohit3523 75e2166
revert
Rohit3523 72abc55
more change
Rohit3523 a12b65b
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 f3d6cdb
chore: format code and fix lint issues
Rohit3523 0a28cbe
rerun ci
Rohit3523 121329c
revert
Rohit3523 a393624
Merge branch 'reanimated-v4' into react-native-81
Rohit3523 d3e9940
Add comment for list item
Rohit3523 052b529
ios file format
Rohit3523 786fb21
correct a11y label
Rohit3523 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| { | ||
| "name": "RocketChatRN" | ||
| "name": "RocketChatRN", | ||
| "plugins": ["@react-native-community/datetimepicker", "expo-web-browser"] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 596
🏁 Script executed:
Repository: RocketChat/Rocket.Chat.ReactNative
Length of output: 1441
Add
usesCleartextTraffictomanifestPlaceholdersinandroid/app/build.gradle.The placeholder
${usesCleartextTraffic}is used inAndroidManifest.xmlbut is not defined in themanifestPlaceholdersmap. Updateandroid/app/build.gradleline 95 to include this variable:Without this definition, the build will fail or the placeholder will remain unexpanded in the manifest.
🤖 Prompt for AI Agents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Rohit3523 have you checked this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is mentioned in upgrade helper, https://react-native-community.github.io/upgrade-helper/?from=0.79.4&to=0.81.5#RnDiffApp-android-app-src-main-AndroidManifest.xml