Skip to content

test: add test to ensure multiple parallel saml logins work and use their respective redirectUrl#34866

Closed
pierre-lehnen-rc wants to merge 5 commits intodevelopfrom
chore/saml-parallel-logins
Closed

test: add test to ensure multiple parallel saml logins work and use their respective redirectUrl#34866
pierre-lehnen-rc wants to merge 5 commits intodevelopfrom
chore/saml-parallel-logins

Conversation

@pierre-lehnen-rc
Copy link
Contributor

@pierre-lehnen-rc pierre-lehnen-rc commented Jan 2, 2025

Proposed changes (including videos or screenshots)

Issue(s)

The test reproduces the error reported on SUP-719.

Steps to test or reproduce

Further comments

This PR only adds the test for this issue, without providing a fix. So the test will fail. Once the issue is fixed, the test should start passing.

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jan 2, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jan 2, 2025

⚠️ No Changeset found

Latest commit: 3817711

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 2, 2025

PR Preview Action v1.4.8
🚀 Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34866/
on branch gh-pages at 2025-01-07 16:55 UTC

@codecov
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.18%. Comparing base (d3fb166) to head (3817711).
Report is 16 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34866   +/-   ##
========================================
  Coverage    59.18%   59.18%           
========================================
  Files         2821     2821           
  Lines        67598    67598           
  Branches     15045    15045           
========================================
  Hits         40011    40011           
  Misses       24773    24773           
  Partials      2814     2814           
Flag Coverage Δ
unit 74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@pierre-lehnen-rc pierre-lehnen-rc marked this pull request as ready for review January 3, 2025 15:07
@pierre-lehnen-rc pierre-lehnen-rc requested a review from a team as a code owner January 3, 2025 15:07
@ggazzo ggazzo changed the title chore: add test to ensure multiple parallel saml logins work and use their respective redirectUrl test: add test to ensure multiple parallel saml logins work and use their respective redirectUrl Jan 3, 2025
@aleksandernsilva aleksandernsilva added this to the 7.3.0 milestone Jan 3, 2025
@matheusbsilva137 matheusbsilva137 added the stat: QA assured Means it has been tested and approved by a company insider label Jan 6, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 6, 2025
@matheusbsilva137
Copy link
Contributor

I added this test to the fix PR (#34873)

@tassoevan tassoevan deleted the chore/saml-parallel-logins branch July 30, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants