Skip to content

test: add test to ensure multiple parallel saml logins work and use their respective redirectUrl #34866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pierre-lehnen-rc wants to merge 5 commits into from
Closed

test: add test to ensure multiple parallel saml logins work and use their respective redirectUrl #34866

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2178c33
chore: add test to ensure multiple parallel saml logins work and use …
pierre-lehnen-rc Jan 2, 2025
b8c392d
add temporary .fail to the new test so it can be merged into develop …
pierre-lehnen-rc Jan 3, 2025
8fa1ade
Merge branch 'develop' into chore/saml-parallel-logins
kodiakhq[bot] Jan 6, 2025
006a47b
Merge branch 'develop' into chore/saml-parallel-logins
kodiakhq[bot] Jan 6, 2025
3817711
expect buttons to be visible before clicking them, to avoid flaky res…
pierre-lehnen-rc Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions apps/meteor/tests/e2e/saml.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,36 @@ test.describe('SAML', () => {
});
});

// #TODO: Fix this issue and remove the .fail from this test
test.fail('Respect redirectUrl on multiple parallel logins', async ({ page, browser }) => {
const page2 = await browser.newPage({ storageState: Users.samluser2.state });
const poRegistration2 = new Registration(page2);

await page2.goto(`/home`);
await expect(page2).toHaveURL('/home');
await expect(page2.getByRole('button', { name: 'User menu' })).not.toBeVisible();

await page.goto(`/invite/${inviteId}`);
await page.getByRole('link', { name: 'Back to Login' }).click();

await poRegistration.btnLoginWithSaml.click();
await expect(page).toHaveURL(/.*\/simplesaml\/module.php\/core\/loginuserpass.php.*/);

await poRegistration2.btnLoginWithSaml.click();
await expect(page2).toHaveURL(/.*\/simplesaml\/module.php\/core\/loginuserpass.php.*/);

await page.getByLabel('Username').fill('samluser1');
await page.getByLabel('Password').fill('password');
await page.locator('role=button[name="Login"]').click();

await page2.getByLabel('Username').fill('samluser2');
await page2.getByLabel('Password').fill('password');
await page2.locator('role=button[name="Login"]').click();

await expect(page).toHaveURL(`/group/${targetInviteGroupName}`);
await expect(page2).toHaveURL('/home');
});

test.fixme('User Merge - By Custom Identifier', async () => {
// Test user merge with a custom identifier configured in the fieldmap
});
Expand Down