regression: sidebar scrolling horizontally

[juliajforesti]

Proposed changes (including videos or screenshots)

Remove class from the sidebar item menu button, as it is already present on its parent element. The style rules of this class was causing a horizontal scroll on the sidebar of the new navigation.

Issue(s)

Steps to test or reproduce

Further comments

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 781b951

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (61c2753) to head (781b951).
Report is 2 commits behind head on release-7.3.0.

Additional details and impacted files

@@              Coverage Diff               @@
##           release-7.3.0   #35048   +/-   ##
==============================================
  Coverage          59.17%   59.17%           
==============================================
  Files               2821     2821           
  Lines              68131    68131           
  Branches           15152    15152           
==============================================
  Hits               40316    40316           
  Misses             24981    24981           
  Partials            2834     2834           

Flag	Coverage Δ
unit	74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35048/
Built to branch gh-pages at 2025-01-28 19:57 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[dougfabris]

I think there are some reason why I added this class to the menu, please give me some time to look into it, until we get it merged

[tassoevan]

@dougfabris I went ahead with because, regardless of the reasoning, it isn't right. Please keep investigating; an edge case can be covered in a patch.

[dougfabris]