Skip to content

regression: sidebar scrolling horizontally #35048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tassoevan merged 2 commits into from
Jan 29, 2025
Merged

regression: sidebar scrolling horizontally #35048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccc9f2b
regression: remove class from sidebar menu button
juliajforesti Jan 28, 2025
781b951
test: adjust sidebar item menu locator
juliajforesti Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/meteor/client/sidebarv2/RoomMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ const RoomMenu = ({ rid, unread, threadUnread, alert, roomOpen, type, cl, name =
const isUnread = alert || unread || threadUnread;
const sections = useRoomMenuActions({ rid, type, name, isUnread, cl, roomOpen, hideDefaultOptions });

return <GenericMenu detached className='rcx-sidebar-item__menu' title={t('Options')} mini aria-keyshortcuts='alt' sections={sections} />;
return <GenericMenu detached title={t('Options')} mini aria-keyshortcuts='alt' sections={sections} />;
};

export default memo(RoomMenu);
2 changes: 1 addition & 1 deletion apps/meteor/tests/e2e/page-objects/fragments/sidebar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ export class Sidebar {
async markItemAsUnread(item: Locator): Promise<void> {
await item.hover();
await item.focus();
await item.locator('.rcx-sidebar-item__menu').click();
await item.getByRole('button', { name: 'Options', exact: true }).click();
await this.page.getByRole('menuitem', { name: 'Mark Unread' }).click();
}

Expand Down
Loading