chore(desktop): Remove non-functional "none" option from notification sound dropdown#35155
Closed
Ansh-dS wants to merge 2 commits intoRocketChat:developfrom
Ansh-dS:chore/remove-none-option
Closed
chore(desktop): Remove non-functional "none" option from notification sound dropdown#35155Ansh-dS wants to merge 2 commits intoRocketChat:developfrom Ansh-dS:chore/remove-none-option
Ansh-dS wants to merge 2 commits intoRocketChat:developfrom
Ansh-dS:chore/remove-none-option
Conversation
Contributor
|
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Ansh-dS
changed the title
Ansh-dS
changed the title
Member
|
I could be wrong, but the idea of "None" may be to not have any sound |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The "none" option in the notification sound dropdown was not producing any sound. To maintain consistency with the other dropdown menus and avoid user confusion, this option has been removed.
Before
After
Issue(s)
#35158
Steps to test or reproduce