Skip to content

chore(eslint): Relax naming convention for Storybook's Story parameter#36382

Merged
ggazzo merged 1 commit intodevelopfrom
chore/eslint-naming-storybook
Jul 9, 2025
Merged

chore(eslint): Relax naming convention for Storybook's Story parameter#36382
ggazzo merged 1 commit intodevelopfrom
chore/eslint-naming-storybook

Conversation

@tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Jul 8, 2025

Proposed changes (including videos or screenshots)

It allows parameter name Story, commonly used in Storybook decorators.

Issue(s)

ARCH-1699

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 8, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.9.0, but it targets 7.8.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 8, 2025

⚠️ No Changeset found

Latest commit: 932ae6a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36382/

Built to branch gh-pages at 2025-07-08 17:37 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@tassoevan tassoevan added this to the 7.9.0 milestone Jul 8, 2025
@tassoevan tassoevan marked this pull request as ready for review July 8, 2025 15:50
@tassoevan tassoevan requested review from a team as code owners July 8, 2025 15:50
@tassoevan tassoevan force-pushed the chore/eslint-naming-storybook branch from b27c8f0 to 932ae6a Compare July 8, 2025 15:53
@codecov
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.76%. Comparing base (c39ccb5) to head (932ae6a).
Report is 3 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #36382   +/-   ##
========================================
  Coverage    64.75%   64.76%           
========================================
  Files         3156     3156           
  Lines       104879   104889   +10     
  Branches     19956    19962    +6     
========================================
+ Hits         67915    67930   +15     
+ Misses       34284    34269   -15     
- Partials      2680     2690   +10     
Flag Coverage Δ
e2e 57.62% <ø> (+0.03%) ⬆️
unit 69.46% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 9, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 9, 2025
@ggazzo ggazzo merged commit 19c4f60 into develop Jul 9, 2025
128 of 139 checks passed
@ggazzo ggazzo deleted the chore/eslint-naming-storybook branch July 9, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants