Skip to content

chore: Rooms store#36439

Merged
ggazzo merged 33 commits intodevelopfrom
chore/rooms-store
Jul 16, 2025
Merged

chore: Rooms store#36439
ggazzo merged 33 commits intodevelopfrom
chore/rooms-store

Conversation

@ggazzo
Copy link
Member

@ggazzo ggazzo commented Jul 16, 2025

reintroduce #36324
ARCH-1671

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Jul 16, 2025

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

@changeset-bot
Copy link

changeset-bot bot commented Jul 16, 2025

⚠️ No Changeset found

Latest commit: 6839921

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ggazzo ggazzo added this to the 7.9.0 milestone Jul 16, 2025
@ggazzo ggazzo marked this pull request as ready for review July 16, 2025 02:57
@ggazzo ggazzo requested review from a team as code owners July 16, 2025 02:57
@github-actions
Copy link
Contributor

PR Preview Action v1.6.2

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-36439/

Built to branch gh-pages at 2025-07-16 03:00 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@codecov
Copy link

codecov bot commented Jul 16, 2025

Codecov Report

Attention: Patch coverage is 74.74403% with 74 lines in your changes missing coverage. Please review.

Project coverage is 68.77%. Comparing base (7ab18f5) to head (6839921).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #36439      +/-   ##
===========================================
+ Coverage    65.45%   68.77%   +3.31%     
===========================================
  Files         3169     2858     -311     
  Lines       104858    93511   -11347     
  Branches     19978    17301    -2677     
===========================================
- Hits         68636    64311    -4325     
+ Misses       33542    27227    -6315     
+ Partials      2680     1973     -707     
Flag Coverage Δ
e2e 58.20% <77.12%> (+0.01%) ⬆️
e2e-api ?
unit 70.56% <58.12%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jul 16, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jul 16, 2025
@ggazzo ggazzo merged commit d277737 into develop Jul 16, 2025
53 checks passed
@ggazzo ggazzo deleted the chore/rooms-store branch July 16, 2025 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants