Skip to content

fix: Browser slowdown when multiple tabs are open #37660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kodiakhq merged 4 commits into from
Jan 8, 2026
Merged

fix: Browser slowdown when multiple tabs are open #37660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12bc6fb
fix: rare useEffect cycle with multiple tabs
cardoso Dec 1, 2025
75f9a8f
Fix rare useEffect cycle with multiple tabs
cardoso Dec 30, 2025
c4653cd
Update changeset
gabriellsh Jan 8, 2026
08c0da5
Merge branch 'develop' into fix/CORE-1543
kodiakhq[bot] Jan 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fifty-starfishes-collect.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@rocket.chat/meteor": patch
---

Fixes browser slowdowns by preventing a rare cascading of language preference updates when multiple tabs reload
17 changes: 10 additions & 7 deletions apps/meteor/client/providers/UserProvider/UserProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { useLocalStorage } from '@rocket.chat/fuselage-hooks';
import { createPredicateFromFilter } from '@rocket.chat/mongo-adapter';
import { afterLogoutCleanUpCallback } from '@rocket.chat/ui-client';
import type { FindOptions, SubscriptionWithRoom } from '@rocket.chat/ui-contexts';
import { UserContext, useEndpoint, useRouteParameter, useSearchParameter } from '@rocket.chat/ui-contexts';
import { UserContext, useRouteParameter, useSearchParameter } from '@rocket.chat/ui-contexts';
import { useQueryClient } from '@tanstack/react-query';
import { Accounts } from 'meteor/accounts-base';
import { Meteor } from 'meteor/meteor';
Expand Down Expand Up @@ -79,8 +79,6 @@ const UserProvider = ({ children }: UserProviderProps): ReactElement => {
const samlCredentialToken = useSearchParameter('saml_idp_credentialToken');
const inviteTokenHash = useRouteParameter('hash');

const setUserPreferences = useEndpoint('POST', '/v1/users.setPreferences');

useEmailVerificationWarning(user ?? undefined);
useClearRemovedRoomsHistory(userId);

Expand Down Expand Up @@ -156,17 +154,22 @@ const UserProvider = ({ children }: UserProviderProps): ReactElement => {
[userId, user, querySubscription, querySubscriptions],
);

// Mirror local preference changes into the live userLanguage state without hitting the server.
useEffect(() => {
if (!!userId && preferedLanguage !== userLanguage) {
setUserPreferences({ data: { language: preferedLanguage } });
setUserLanguage(preferedLanguage);
if (preferedLanguage === userLanguage) {
return;
}

setUserLanguage(preferedLanguage);
}, [preferedLanguage, setUserLanguage, userLanguage]);

// When the server reports a new language, overwrite both storage keys so every tab stays aligned.
useEffect(() => {
if (user?.language !== undefined && user.language !== userLanguage) {
setUserLanguage(user.language);
setPreferedLanguage(user.language);
}
}, [preferedLanguage, setPreferedLanguage, setUserLanguage, user?.language, userLanguage, userId, setUserPreferences]);
}, [setPreferedLanguage, setUserLanguage, user?.language, userLanguage]);

useEffect(() => {
if (!samlCredentialToken && !inviteTokenHash) {
Expand Down
Loading