fix: remove sensitive information from outgoingLogger logs#37729
fix: remove sensitive information from outgoingLogger logs#37729
Conversation
|
Looks like this PR is ready to merge! 🎉 |
🦋 Changeset detectedLatest commit: 199f063 The changes in this PR will be included in the next version bump. This PR includes changesets to release 41 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughSplits roomJoined/roomLeft argument handling and normalizes roomLeft user payload; changes debug logging to emit only explicit identifiers (messageId, roomId, userId) instead of full event objects to remove sensitive message content from outgoing debug logs. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (5 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #37729 +/- ##
===========================================
+ Coverage 67.78% 67.79% +0.01%
===========================================
Files 3449 3454 +5
Lines 113987 114065 +78
Branches 20956 21002 +46
===========================================
+ Hits 77262 77335 +73
Misses 34610 34610
- Partials 2115 2120 +5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
e5d2518 to
199f063
Compare
Proposed changes (including videos or screenshots)
As part of SUP-931 and VLN-163, we are removing sensitive information from
outgoingLogger.debuglogs while keeping entity IDs visible for debugging purposes.During this change, we identified that the
roomLeftevent is currently reporting the user as{ user: IUser }instead of the expected direct user object and a fix was implemented (CORE-1557).Issue(s)
Steps to test or reproduce
Further comments
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.