Skip to content

fix: remove sensitive information from outgoingLogger logs #37729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggazzo merged 2 commits into from
Dec 11, 2025
Merged

fix: remove sensitive information from outgoingLogger logs #37729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b21c99d
fix!: remove sensitive information from outgoingLogger logs
ricardogarim Dec 8, 2025
199f063
add changesets
ricardogarim Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/thick-wasps-turn.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Fixes inconsistency in roomLeft event payload by aligning it to the standard outgoing events signature.
5 changes: 5 additions & 0 deletions .changeset/tricky-trees-tan.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rocket.chat/meteor': patch
---

Removes sensitive data from outgoing events debug logs.
11 changes: 9 additions & 2 deletions apps/meteor/app/integrations/server/lib/triggerHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,12 +216,17 @@ class RocketChatIntegrationHandler {
}
break;
case 'roomJoined':
case 'roomLeft':
if (args.length >= 3) {
argObject.user = args[1] as IUser;
argObject.room = args[2] as IRoom;
}
break;
case 'roomLeft':
if (args.length >= 3) {
argObject.user = (args[1] as { user: IUser })?.user;
argObject.room = args[2] as IRoom;
}
break;
case 'userCreated':
if (args.length >= 2) {
argObject.user = args[1] as IUser;
Expand All @@ -235,7 +240,9 @@ class RocketChatIntegrationHandler {

outgoingLogger.debug({
msg: `Got the event arguments for the event: ${argObject.event}`,
argObject,
messageId: argObject.message?._id,
roomId: argObject.room?._id,
userId: argObject.user?._id || argObject.owner?._id,
});

return argObject;
Expand Down
Loading