Skip to content

Conversation

@KnifMelti
Copy link
Contributor

@KnifMelti KnifMelti commented Mar 14, 2025

Proposed Changes

  • Making sure the imported $app-override.txt/$app-custom.txt are TRIM:ed before import to the variable
  • Winget-Install needs Compare-SemVer too
  • $AppArgs in WinGet -Uninstall too

Branch name error (should be develop/trimraw)

Related Issues

#881 #785

@KnifMelti KnifMelti changed the base branch from main to develop March 14, 2025 22:43
@KnifMelti
Copy link
Contributor Author

@Romanitho KICS is gone, but:
image

@Romanitho
Copy link
Owner

@KnifMelti
Copy link
Contributor Author

KnifMelti commented Mar 15, 2025

[404] https://github.com/user-attachments/assets/f0ec4047-d66c-4277-a39c-763fd7516ad8 | Network error: Not Found

Yes, thats your screenshot that is missing. Haven't touched it...
...should I delete it?

@KnifMelti
Copy link
Contributor Author

@Romanitho Your commit:
f4d8afd

@Romanitho
Copy link
Owner

Don't know why it was dead. Screenshot is back

@KnifMelti
Copy link
Contributor Author

Don't know why it was dead. Screenshot is back

image

@KnifMelti
Copy link
Contributor Author

No go with that link:
image

@Romanitho
Copy link
Owner

for me you don't have to touch anything regarding the image. It will be merged automatically

@KnifMelti
Copy link
Contributor Author

Then I'll let it be now with this latest link? Or should I revert back to the old?

Copy link
Owner

@Romanitho Romanitho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for me, juste revert this commit 291d8bc

@Romanitho
Copy link
Owner

Is the compare-semver function used in Winget-Install.ps1?

@Romanitho
Copy link
Owner

do not pay attention to megalinter. I'll merged it anyway. The link is fixed in my main branch

@KnifMelti
Copy link
Contributor Author

Is the compare-semver function used in Winget-Install.ps1?

Yes, via Install-Prerequisites.ps1

@Romanitho
Copy link
Owner

Very true. We probably need to rework the entire code soon. There have been too many changes since the beginning.

@Romanitho Romanitho merged commit 829d98d into Romanitho:develop Mar 15, 2025
1 of 2 checks passed
@KnifMelti KnifMelti deleted the hotfix/trimraw branch March 15, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants