Added new issue type for working within a fork & fixed the bug with local .roomodes not overriding global configs #1030
Conversation
Create simpleissue.yaml
Branch update
Related to #12 Add error handling for invalid `.roomodes` JSON syntax and display error message in RED on the "Prompts" page. * **CustomModesManager.ts** - Add `errorState` property to store error messages. - Update `loadModesFromFile` method to catch JSON syntax errors and set the error state. - Add `getErrorState`, `setErrorState`, and `clearErrorState` methods to manage the error state. * **CustomModesManager.test.ts** - Add tests to verify that an error message is displayed when there is an error in the `.roomodes` JSON syntax. - Update existing tests to handle the new error state logic. * **PromptsView.tsx** - Add `errorState` to component state. - Add logic to fetch the error state from `CustomModesManager` and update the component state. - Display the error message in RED beside the word "Modes" when there is an error in the `.roomodes` JSON syntax. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/richardwhiteii/Roo-Code/issues/12?shareId=XXXX-XXXX-XXXX-XXXX).
updating from main.
Just adding more detail to this issues type. Based on the current ISSUE_TEMPLATE structure, it is difficult to just create an issue within a fork. This issue type allows for quickly capture an idea as an issue, without the overhead that is beneficial when contributing to the larger repo.
… PromptsView to eliminate unused error state
update from origin
from origin
[Fork] .roomodes json syntax
richardwhiteii
requested review from
ColemanRoo,
cte,
mrubens and
stea9499
as code owners
|
.gitignore
Outdated
| .roomodes | ||
| .gitignore |
There was a problem hiding this comment.
I don't think we want to ignore these two
There was a problem hiding this comment.
I updated my branch and removed that update.
| @@ -0,0 +1,14 @@ | |||
| name: Fork Issue | |||
There was a problem hiding this comment.
Can you help me understand this one? Does the existing issue type not work within the forks?
There was a problem hiding this comment.
Yes the existing issues work inside the fork. For me, when I create an issue inside my fork, at that point I'm really having a conversation with myself. The current options don't let me just create a ticket that says review the documentation and create documentation about [insert feature]. The other templates are absolutely valid at the repository level because you need to collect information to make decisions. I imagine you are able to discern someone's seriousness in the detail they provide in that format. At the fork level, I might be creating a range of issues, that could turn into prompts to address the finding. That is challenging with the other formats.
removed .roomodes .gitignore based on feedback.
new pull request
|
I'm withdrawing this pr, and am replacing it with a focused change. |
2 participants
Description
Added new issue type for working within a fork & fixed the bug with local .roomodes not overriding global configs
The roomodes bug prevented the project specific configuration from being ready and was always overwritten by global.
Type of change
How Has This Been Tested?
I installed the update and was able to get the system prompt to change.
For the issue I created a new issue. The new issue type reduces the overhead associated with creating issues within a local branch.
Checklist:
Additional context
There were no document changes.
Related Issues
Reviewers
Important
Add new issue template for forks and fix role definition override bug in
generatePrompt()insystem.ts.simpleissue.yamlfor creating issues within a fork.system.ts, changed role definition assignment ingeneratePrompt()to prioritizemodeConfig.roleDefinitionoverpromptComponent.roleDefinition.This description was created by
for f6804ac. It will automatically update as commits are pushed.