-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added new issue type for working within a fork & fixed the bug with local .roomodes not overriding global configs #1030
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
4137c02
Create simpleissue.yaml
richardwhiteii 12adde0
Merge pull request #1 from richardwhiteii/simple-issue
richardwhiteii c8ceb0d
Merge pull request #4 from RooVetGit/main
richardwhiteii 5b070bb
Merge pull request #7 from RooVetGit/main
richardwhiteii a81f21f
[Fork] .roomodes json syntax
richardwhiteii cf3e3cc
updated
51a59a1
Merge pull request #14 from RooVetGit/main
richardwhiteii a5c3039
Update simpleissue.yaml
richardwhiteii c8ce439
Fix loading of roomodes modes and adjust role definition fallback logic
f7bf7a8
Refactor CustomModesManager to remove error state handling and update…
17f77b6
Merge pull request #15 from RooVetGit/main
richardwhiteii c087088
Merge pull request #16 from RooVetGit/main
richardwhiteii 5b57244
Remove simple issue template from GitHub repository
609920c
Update .gitignore to include .devcontainer and .roomodes directories
57d41e5
Fix optional chaining for role definition retrieval in generatePrompt…
f6804ac
Merge pull request #13 from richardwhiteii/fix-roomodes-json-syntax
richardwhiteii 7698623
Update .gitignore
richardwhiteii 31b28aa
Merge branch 'RooVetGit:main' into main
richardwhiteii edbb093
Merge pull request #18 from RooVetGit/main
richardwhiteii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| name: Fork Issue | ||
| description: Create a simple issue to track changes when working inside the fork, before going to main. | ||
| title: "[Fork] " | ||
| labels: [] | ||
| assignees: [] | ||
| body: | ||
| - type: textarea | ||
| id: description | ||
| attributes: | ||
| label: Description | ||
| description: Describe the purpose of this fork and any planned changes | ||
| placeholder: Type your description here... | ||
| validations: | ||
| required: true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -28,3 +28,4 @@ docs/_site/ | |
|
|
||
| #Logging | ||
| logs | ||
| .devcontainer | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help me understand this one? Does the existing issue type not work within the forks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the existing issues work inside the fork. For me, when I create an issue inside my fork, at that point I'm really having a conversation with myself. The current options don't let me just create a ticket that says review the documentation and create documentation about [insert feature]. The other templates are absolutely valid at the repository level because you need to collect information to make decisions. I imagine you are able to discern someone's seriousness in the detail they provide in that format. At the fork level, I might be creating a range of issues, that could turn into prompts to address the finding. That is challenging with the other formats.