refactor: Enhance checkpoint file exclusion system#1363
Closed
hannesrudolph wants to merge 1 commit intoRooCodeInc:mainfrom
Closed
refactor: Enhance checkpoint file exclusion system#1363hannesrudolph wants to merge 1 commit intoRooCodeInc:mainfrom
hannesrudolph wants to merge 1 commit intoRooCodeInc:mainfrom
Conversation
Comprehensive update to the checkpoints exclusion module: - Modularized exclusion patterns into category-specific functions - Added detailed documentation for file filtering strategy - Introduced new utility functions for Git LFS pattern handling - Expanded coverage of excluded file types and patterns - Improved maintainability and extensibility of exclusion rules
|
Collaborator
Author
|
@mrubens shred me.. what did I miss? |
Contributor
|
coool |
Collaborator
|
Closing in favor of #1420. |
Collaborator
Author
|
@cte much better job. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comprehensive update to the checkpoints exclusion module:
Context
Comprehensive update to the checkpoints exclusion module: The changes refactor the checkpoint file exclusion system, improving its organization, extensibility, and coverage of files that should be excluded when creating checkpoints. This reduces checkpoint size and improves performance by avoiding unnecessary tracking of irrelevant files.
Implementation
The changes modularize the exclusion logic in
src/services/checkpoints/constants.ts. Previously, all exclusion patterns were defined in a single large array (GIT_EXCLUDES). The refactoring introduces several key improvements:getBuildArtifactPatterns(),getMediaFilePatterns(),getCacheFilePatterns(), etc. This improves readability and makes it easier to manage and update specific types of exclusions.CheckpointExclusionsmodule. This documentation clarifies the file filtering strategy and how the different parts of the module work together.getDefaultExclusions(),writeExcludesFile(), andgetLfsPatterns(), have been added to handle Git LFS pattern integration and writing the combined exclusion patterns to Git's exclude file.getDefaultExclusions()function: This function now combines all category-specific exclusions and also incorporates Git LFS patterns. The oldGIT_EXCLUDESis deprecated and now just callsgetDefaultExclusions().ExclusionResultInterface: This interface is added to define the return of an exclusion check.Screenshots
Important
Refactor
constants.tsto modularize checkpoint exclusion patterns, add utility functions for Git LFS, and expand excluded file types.src/services/checkpoints/constants.tsto use category-specific functions for exclusion patterns, such asgetBuildArtifactPatterns(),getMediaFilePatterns(), etc.GIT_EXCLUDESin favor ofgetDefaultExclusions().getDefaultExclusions(),writeExcludesFile(), andgetLfsPatterns()for handling Git LFS patterns and writing exclusion patterns.CheckpointExclusionsmodule and its file filtering strategy.ExclusionResultinterface to define the return of an exclusion check.This description was created by
for ed83d53. It will automatically update as commits are pushed.
THANK YOU CLINE