Skip to content

Fix: Custom temperature cannot be unchecked #1468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 1 commit into from
Mar 8, 2025
Merged

Fix: Custom temperature cannot be unchecked #1468

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/shared/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export interface ApiHandlerOptions {
requestyApiKey?: string
requestyModelId?: string
requestyModelInfo?: ModelInfo
modelTemperature?: number
modelTemperature?: number | null
modelMaxTokens?: number
modelMaxThinkingTokens?: number
}
Expand Down
10 changes: 5 additions & 5 deletions webview-ui/src/components/settings/TemperatureControl.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import { useEffect, useState } from "react"
import { useDebounce } from "react-use"

interface TemperatureControlProps {
value: number | undefined
onChange: (value: number | undefined) => void
value: number | undefined | null
onChange: (value: number | undefined | null) => void
maxValue?: number // Some providers like OpenAI use 0-2 range
}

Expand All @@ -14,7 +14,7 @@ export const TemperatureControl = ({ value, onChange, maxValue = 1 }: Temperatur
useDebounce(() => onChange(inputValue), 50, [onChange, inputValue])
// Sync internal state with prop changes when switching profiles
useEffect(() => {
const hasCustomTemperature = value !== undefined
const hasCustomTemperature = value !== undefined && value !== null
setIsCustomTemperature(hasCustomTemperature)
setInputValue(value)
}, [value])
Expand All @@ -28,7 +28,7 @@ export const TemperatureControl = ({ value, onChange, maxValue = 1 }: Temperatur
const isChecked = e.target.checked
setIsCustomTemperature(isChecked)
if (!isChecked) {
setInputValue(undefined) // Unset the temperature
setInputValue(null) // Unset the temperature, note that undefined is unserializable
} else {
setInputValue(value ?? 0) // Use the value from apiConfiguration, if set
}
Expand All @@ -53,7 +53,7 @@ export const TemperatureControl = ({ value, onChange, maxValue = 1 }: Temperatur
min="0"
max={maxValue}
step="0.01"
value={inputValue}
value={inputValue ?? 0}
className="h-2 focus:outline-0 w-4/5 accent-vscode-button-background"
onChange={(e) => setInputValue(parseFloat(e.target.value))}
/>
Expand Down
2 changes: 1 addition & 1 deletion webview-ui/src/components/settings/__tests__/TemperatureControl.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ describe("TemperatureControl", () => {
fireEvent.click(checkbox)
// Waiting for debounce
await new Promise((x) => setTimeout(x, 100))
expect(onChange).toHaveBeenCalledWith(undefined)
expect(onChange).toHaveBeenCalledWith(null)

// Check - should restore previous temperature
fireEvent.click(checkbox)
Expand Down
Loading