fix: prevent negative line index when maxReadFileLine is zero

[KJ7LNW]

Context

Fixed an issue where the read_file tool would fail when maxReadFileLine=0, as the code attempted to access a negative line index.

Implementation

Added checks to:

• Only call readLines when maxReadFileLine > 0
• Return empty string when maxReadFileLine = 0

Before

After

works :)

How to Test

• Set maxReadFileLine=0 in VS Code settings
• Use read_file tool on any file
• Verify it completes successfully instead of throwing an error

Get in Touch

Discord: KJ7LNW

---

Important

Fixes negative line index error in Cline.ts for read_file tool when maxReadFileLine=0.

• Behavior:
  • Fixes issue in Cline.ts where read_file tool fails with maxReadFileLine=0 by preventing negative line index access.
  • Adds check to only call readLines if maxReadFileLine > 0.
  • Returns empty string if maxReadFileLine = 0.
• Code Changes:
  • Modifies Cline.ts to include conditional logic around readLines call and content assignment.
  • Updates logic to handle empty content when no lines are read.

^{This description was created by for fc82873. It will automatically update as commits are pushed.}

[mrubens]

Hmmm, what does it even mean to have a max of 0 for this? We might want to have a floor for this setting, like 100 lines.

[KJ7LNW]

Hmmm, what does it even mean to have a max of 0 for this? We might want to have a floor for this setting, like 100 lines.

It means read_file only shows declaration content and then it uses start/end_line to load only what it needs for incredibly small context. give it a try, it works quite well

[mrubens]

Hmmm, what does it even mean to have a max of 0 for this? We might want to have a floor for this setting, like 100 lines.

It means read_file only shows declaration content and then it uses start/end_line to load only what it needs for incredibly small context. give it a try, it works quite well

Ah interesting, I see what you mean. I wonder if we need to change the copy around the setting then to make it more clear that it’s not a hard max, it’s just the default chunk size. Separate from this PR.

[KJ7LNW]

good idea

[changeset-bot]

⚠️ No Changeset found

Latest commit: b0cb47b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[mrubens]

Merged in #1915. Thanks!