Skip to content

fix: prevent negative line index when maxReadFileLine is zero #1910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KJ7LNW wants to merge 2 commits into from
Closed

fix: prevent negative line index when maxReadFileLine is zero #1910

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc82873
fix: prevent negative line index when maxReadFileLine is zero
Mar 22, 2025
b0cb47b
Update src/core/Cline.ts
mrubens Mar 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Cline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2341,11 +2341,11 @@ export class Cline extends EventEmitter<ClineEvents> {
isFileTruncated = true

const res = await Promise.all([
readLines(absolutePath, maxReadFileLine - 1, 0),
maxReadFileLine > 0 ? readLines(absolutePath, maxReadFileLine - 1, 0) : "",
parseSourceCodeDefinitionsForFile(absolutePath, this.rooIgnoreController),
])

content = addLineNumbers(res[0])
content = res[0].length > 0 ? addLineNumbers(res[0]) : ""
const result = res[1]
if (result) {
sourceCodeDef = `\n\n${result}`
Expand Down