Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Dec 27, 2024

I accidentally introduced a bug in #220 - turns out we need to make sure it's a tool ask


Important

Fixes auto-approval bug in ChatView.tsx to ensure only tool requests are auto-approved when alwaysAllowWrite is enabled.

  • Behavior:
    • Fixes bug in ChatView.tsx where non-tool requests were incorrectly auto-approved when alwaysAllowWrite was enabled.
    • Ensures only tool requests with ask: 'tool' are auto-approved.
  • Tests:
    • Adds test in ChatView.test.tsx to verify auto-approval only occurs for tool requests.
    • Confirms non-tool requests are not auto-approved even if alwaysAllowWrite is enabled.

This description was created by Ellipsis for 91399c9. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2024

🦋 Changeset detected

Latest commit: 91399c9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
roo-cline Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrubens mrubens merged commit bcc6864 into main Dec 27, 2024
6 checks passed
@mrubens mrubens deleted the fix_auto_approve_commands branch December 27, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants