fix: Prevent unnecessary autoscroll when buttons appear (#1280) #2334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
dosubot
bot
added
the
size:XS
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
mrubens
approved these changes
Apr 7, 2025
Collaborator
mrubens
left a comment
mrubens
left a comment
There was a problem hiding this comment.
Seems to work well for me! Great find 🙏
github-project-automation
bot
moved this from PR [Pre Approval Review]
to Done
in Roo Code Roadmap
monotykamary
pushed a commit
to monotykamary/Roo-Code
that referenced
this pull request
Apr 19, 2025
…ching mechanism, and fix the issue of inaccurate SEARCH-REPLACE delimiters generated by some large models through lookahead processing (RooCodeInc#2334) * Fix the chat context menu removing UTF8 characters causing pure UTF8 character filenames not to display in the menu * fix: Refactor the function constructNewFileContent using a state switching mechanism, and fix the issue of inaccurate SEARCH-REPLACE delimiters generated by some large models through lookahead processing * Merge diff.ts with diff2.ts; Mark the original constructNewFileContent as @deprecated. * Add detailed comments to explain test cases for nested markers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #1280.
Previously, when interactive elements like API request or command execution buttons appeared in the chat view, the view would automatically scroll to the bottom, even if the user had manually scrolled up. This could interrupt the user's reading flow.
This change modifies the autoscroll logic to prevent this specific behavior. The chat will no longer automatically scroll down just because new buttons have rendered, unless the user is already scrolled to the bottom.
Important
Prevents unnecessary autoscroll in
ChatView.tsxwhen new buttons appear unless user is at the bottom.ChatView.tsxwhen new buttons appear unless user is at the bottom.disableAutoScrollRef.current = falsein two places to achieve this.This description was created by
for 338c3f7. It will automatically update as commits are pushed.