Fix duplicate mention suggestion #2528
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t menu item keys more accurately
dosubot
bot
added
the
size:S
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| item.type === ContextMenuOptionType.Folder || | ||
| item.type === ContextMenuOptionType.OpenedFile | ||
| ) { | ||
| key = normalizedValue! |
Contributor
There was a problem hiding this comment.
Using the non-null assertion (!) on normalizedValue may be risky because item.value is optional. Consider handling the undefined case explicitly.
Suggested change
| key = normalizedValue! | |
| key = normalizedValue ?? '' |
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix duplicate mention suggestion
Context
When exist open tab, and mention file that is open mention suggest will show 2 duplicate value for open tab
Implementation
Screenshots
How to Test
Get in Touch
Important
Fixes duplicate mention suggestions in
getContextMenuOptions()by adjusting deduplication logic forFile,Folder, andOpenedFiletypes.getContextMenuOptions()incontext-mentions.tsby adjusting deduplication logic.File,Folder, andOpenedFiletypes by usingnormalizedValuedirectly as the key.This description was created by
for 3fc4ce9. It will automatically update as commits are pushed.