Skip to content

Fix duplicate mention suggestion #2528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrubens merged 1 commit into from
Apr 12, 2025
Merged

Fix duplicate mention suggestion #2528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions webview-ui/src/utils/context-mentions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,17 @@ export function getContextMenuOptions(
const seen = new Set()
const deduped = allItems.filter((item) => {
// Normalize paths for deduplication by ensuring leading slashes
const normalizedValue = item.value && !item.value.startsWith("/") ? `/${item.value}` : item.value
const key = `${item.type}-${normalizedValue}`
const normalizedValue = item.value
let key = ""
if (
item.type === ContextMenuOptionType.File ||
item.type === ContextMenuOptionType.Folder ||
item.type === ContextMenuOptionType.OpenedFile
) {
key = normalizedValue!
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot Apr 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using the non-null assertion (!) on normalizedValue may be risky because item.value is optional. Consider handling the undefined case explicitly.

Suggested change
key = normalizedValue!
key = normalizedValue ?? ''

} else {
key = `${item.type}-${normalizedValue}`
}
if (seen.has(key)) return false
seen.add(key)
return true
Expand Down