-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Remove insert_content tool #2742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
45e5ebc to
7df32e3
Compare
src/core/Cline.ts
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got this error when pushing
src/core/Cline.ts:1398:33 - error TS2366: Function lacks ending return statement and return type does not include 'undefined'.
1398 const toolDescription = (): string => {
~~~~~~
Found 1 error in src/core/Cline.ts:1398
7df32e3 to
c175ef1
Compare
mrubens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel torn on this one. I've heard some people say that insert_content is the only way to get models that can't do diffs to work, but on the other hand I don't really like the idea of experimental features that are rarely used. Is there a version of this that we'd feel comfortable turning on for everyone? Personally I lean toward one that looks more like append_to_file (a simple tool with a single block and a line number). Thoughts?
|
@mrubens or should we keep both insert_content and search_and_replace but we change it to xml, and remove multiple operation and move it from experimental tool ? |
Yeah I might be leaning in that direction. And maybe remove append_to_file in favor of insert_content? |
Context
Remove insert_content tool
Implementation
Screenshots
How to Test
Get in Touch
Important
Remove
insert_contenttool and related configurations, schemas, and tests from the codebase.insert_contenttool fromCline.ts,index.ts, andinsert-groups.ts.insertContentTool.tsandinsert-content.ts.insert_contentfromexperimentIdsinroo-code.tsandschemas/index.ts.experimentsinexperiments.tsandexperiments.test.ts.insert_contentfromGlobalSettingsinroo-code.d.tsandtypes.ts.experimentsSchemainschemas/index.ts.insert_contentrelated tests insystem.test.tsandmodes.test.ts.ExtensionStateContext.test.tsxto reflect changes in experiments.This description was created by
for 45e5ebc922b8424b7e562286d06707e177f2fb0f. It will automatically update as commits are pushed.