Skip to content

Conversation

@samhvw8
Copy link
Contributor

@samhvw8 samhvw8 commented Apr 18, 2025

Context

Remove insert_content tool

Implementation

Screenshots

before after

How to Test

Get in Touch


Important

Remove insert_content tool and related configurations, schemas, and tests from the codebase.

  • Tool Removal:
    • Remove insert_content tool from Cline.ts, index.ts, and insert-groups.ts.
    • Delete insertContentTool.ts and insert-content.ts.
  • Configuration Changes:
    • Remove insert_content from experimentIds in roo-code.ts and schemas/index.ts.
    • Update experiments in experiments.ts and experiments.test.ts.
  • Schema and Type Updates:
    • Remove insert_content from GlobalSettings in roo-code.d.ts and types.ts.
    • Update experimentsSchema in schemas/index.ts.
  • Test Updates:
    • Remove insert_content related tests in system.test.ts and modes.test.ts.
    • Update ExtensionStateContext.test.tsx to reflect changes in experiments.

This description was created by Ellipsis for 45e5ebc922b8424b7e562286d06707e177f2fb0f. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 18, 2025

⚠️ No Changeset found

Latest commit: c175ef1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Apr 18, 2025
@samhvw8 samhvw8 force-pushed the remove-insert-content-tool branch from 45e5ebc to 7df32e3 Compare April 18, 2025 06:17
Comment on lines +1440 to +1441
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got this error when pushing

src/core/Cline.ts:1398:33 - error TS2366: Function lacks ending return statement and return type does not include 'undefined'.

1398 const toolDescription = (): string => {
~~~~~~

Found 1 error in src/core/Cline.ts:1398

@samhvw8 samhvw8 force-pushed the remove-insert-content-tool branch from 7df32e3 to c175ef1 Compare April 18, 2025 06:24
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel torn on this one. I've heard some people say that insert_content is the only way to get models that can't do diffs to work, but on the other hand I don't really like the idea of experimental features that are rarely used. Is there a version of this that we'd feel comfortable turning on for everyone? Personally I lean toward one that looks more like append_to_file (a simple tool with a single block and a line number). Thoughts?

@samhvw8
Copy link
Contributor Author

samhvw8 commented Apr 21, 2025

@mrubens or should we keep both insert_content and search_and_replace but we change it to xml, and remove multiple operation and move it from experimental tool ?

@mrubens
Copy link
Collaborator

mrubens commented Apr 21, 2025

@mrubens or should we keep both insert_content and search_and_replace but we change it to xml, and remove multiple operation and move it from experimental tool ?

Yeah I might be leaning in that direction. And maybe remove append_to_file in favor of insert_content?

@samhvw8 samhvw8 closed this Apr 21, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants