UI: Toggles and border fixes on edge case themes. #3051
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Referenced in #2987 cc @elianiva:
Some themes don't define border colors, so a white border bleeds through. This PR addresses the issue by setting a transparent fallback if
--vscode-input-borderis undefined:Before/After:
For the auto-approve toggles specifically, this also addresses some themes which do not have highly differentiated
defaultandoutlinebutton variants by making the falsy state partially-transparent:Important
Fixes border color and toggle button opacity issues in themes with missing definitions by adding transparent fallbacks and adjusting opacity in
index.cssandAutoApproveToggle.tsx.index.css, set--color-vscode-input-borderto fallback totransparentif--vscode-input-borderis undefined.--bordervariable to usetransparentfallback inindex.css.AutoApproveToggle.tsx, addopacity-50class to toggles in falsy state for better differentiation in themes with similardefaultandoutlinebutton variants.This description was created by
for 82ddde4. You can customize this summary. It will automatically update as commits are pushed.