Skip to content

Conversation

@sachasayan
Copy link
Contributor

@sachasayan sachasayan commented Apr 30, 2025

Context

Referenced in #2987 cc @elianiva:

Some themes don't define border colors, so a white border bleeds through. This PR addresses the issue by setting a transparent fallback if --vscode-input-border is undefined:

Before/After:

Screenshot 2025-04-29 at 8 16 19 PM

For the auto-approve toggles specifically, this also addresses some themes which do not have highly differentiated default and outline button variants by making the falsy state partially-transparent:

Screenshot 2025-04-29 at 8 55 22 PM


Important

Fixes border color and toggle button opacity issues in themes with missing definitions by adding transparent fallbacks and adjusting opacity in index.css and AutoApproveToggle.tsx.

  • CSS Changes:
    • In index.css, set --color-vscode-input-border to fallback to transparent if --vscode-input-border is undefined.
    • Update --border variable to use transparent fallback in index.css.
  • Component Changes:
    • In AutoApproveToggle.tsx, add opacity-50 class to toggles in falsy state for better differentiation in themes with similar default and outline button variants.

This description was created by Ellipsis for 82ddde4. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Apr 30, 2025

⚠️ No Changeset found

Latest commit: 82ddde4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@elianiva elianiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We can explore the idea of making our own token mapping later down the line after your chat UI PR gets merged and my settings UI PR gets merged.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 30, 2025
@cte cte marked this pull request as ready for review April 30, 2025 02:11
@cte cte requested a review from mrubens as a code owner April 30, 2025 02:11
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Apr 30, 2025
@cte cte merged commit 6e4a791 into RooCodeInc:main Apr 30, 2025
28 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Apr 30, 2025
@sachasayan sachasayan deleted the UI/border-fix branch April 30, 2025 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants