Skip to content

UI: Toggles and border fixes on edge case themes. #3051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2025
Merged

UI: Toggles and border fixes on edge case themes. #3051

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webview-ui/src/components/settings/AutoApproveToggle.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ export const AutoApproveToggle = ({ onToggle, ...props }: AutoApproveToggleProps
onClick={() => onToggle(key, !props[key])}
title={t(descriptionKey || "")}
data-testid={testId}
className={cn(" aspect-square h-[80px]")}>
className={cn(" aspect-square h-[80px]", !props[key] && "opacity-50")}>
<span className={cn("flex flex-col items-center gap-1")}>
<span className={`codicon codicon-${icon}`} />
<span className="text-sm text-center">{t(labelKey)}</span>
Expand Down
14 changes: 12 additions & 2 deletions webview-ui/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,10 @@

--color-vscode-input-foreground: var(--vscode-input-foreground);
--color-vscode-input-background: var(--vscode-input-background);
--color-vscode-input-border: var(--vscode-input-border);
--color-vscode-input-border: var(
--vscode-input-border,
transparent
); /* Some themes don't have a border color, so we can fallback to transparent */

--color-vscode-focusBorder: var(--vscode-focusBorder);

Expand Down Expand Up @@ -140,7 +143,7 @@
--accent-foreground: var(--vscode-list-hoverForeground);
--destructive: var(--vscode-errorForeground);
--destructive-foreground: var(--vscode-button-foreground);
--border: var(--vscode-input-border);
--border: var(--vscode-input-border, transparent); /* --border gets theme value or transparent fallback */
--input: var(--vscode-input-background);
--ring: var(--vscode-input-border);
--chart-1: var(--vscode-charts-red);
Expand All @@ -150,6 +153,13 @@
--chart-5: var(--vscode-charts-green);
--radius: 0.5rem;
}

/* Higher specififty than VSCode's theme and root. */
/* Used for baseline theme overrides, but avoid using for styling. */

body {
--vscode-input-border: var(--border);
}
}

@layer components {
Expand Down
Loading