Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 3, 2025

Reverts #3139


Important

Reverts initial state and logic changes in CommandExecution.tsx, potentially reintroducing the empty command bug.

  • Revert Changes:
    • Reverts initial state of command in CommandExecution.tsx from text to an empty string.
    • Modifies logic to set command and output only if COMMAND_OUTPUT_STRING is found in text.
  • Behavior:
    • Affects command processing when no status is set, potentially reintroducing the empty command bug.

This description was created by Ellipsis for 776df15. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2025

⚠️ No Changeset found

Latest commit: 776df15

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label May 3, 2025
if (index !== -1) {
setCommand(text.slice(0, index))
setOutput(text.slice(index + COMMAND_OUTPUT_STRING.length))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the branch that sets command to text when COMMAND_OUTPUT_STRING is not found reintroduces the bug where a valid command isn't displayed. Ensure that for cases with no output marker (index === -1), command should be set to text.

@cte cte closed this May 4, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 4, 2025
@cte cte deleted the revert-3139-cte/fix-empty-command branch May 4, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants