Skip to content

Revert "Fix empty command bug" #3153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Revert "Fix empty command bug" #3153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions webview-ui/src/components/chat/CommandExecution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export const CommandExecution = ({ executionId, text }: CommandExecutionProps) =

const [status, setStatus] = useState<CommandExecutionStatus | null>(null)
const [output, setOutput] = useState("")
const [command, setCommand] = useState(text)
const [command, setCommand] = useState("")

const lines = useMemo(
() => [`$ ${command}`, ...output.split("\n").filter((line) => line.trim() !== "")],
Expand Down Expand Up @@ -79,9 +79,7 @@ export const CommandExecution = ({ executionId, text }: CommandExecutionProps) =
if (!status && text) {
const index = text.indexOf(COMMAND_OUTPUT_STRING)

if (index === -1) {
setCommand(text)
} else {
if (index !== -1) {
setCommand(text.slice(0, index))
setOutput(text.slice(index + COMMAND_OUTPUT_STRING.length))
}
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the branch that sets command to text when COMMAND_OUTPUT_STRING is not found reintroduces the bug where a valid command isn't displayed. Ensure that for cases with no output marker (index === -1), command should be set to text.

Expand Down