Bugfix: litellm models are now flushed before refetching #4079
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
mrubens
reviewed
May 28, 2025
| setRefreshError(t("settings:providers.refreshModels.missingConfig")) | ||
| return | ||
| } | ||
| vscode.postMessage({ type: "flushRouterModels", text: "litellm" }) |
Collaborator
There was a problem hiding this comment.
Is it guaranteed that this will finish before we request the models in the next line? Is there a world where we add some sort of flush: true to the requestRouterModels instead?
Contributor
Author
There was a problem hiding this comment.
The order isn't guaranteed, but I'm addressing that in the refactor. This was just intended to be a hacky one-line mitigation for now. Ok to close this PR if we'd rather hold off for a proper fix
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
Jun 16, 2025
* feat: Added a configurable default terminal profile setting * chore: format * refactor: migrate terminal profiles to gRPC and remove legacy message handling - rename AvailableTerminalProfilesResponse to TerminalProfiles in proto - remove duplicate TerminalProfile type from terminal_types.ts - update all imports to use TerminalProfile from proto/state - remove legacy availableTerminalProfiles message handling from ExtensionStateContext - clean up ExtensionMessage type by removing unused availableTerminalProfiles - translate Spanish comment to English in TerminalSettingsSection - update server-side getAvailableTerminalProfiles to use new proto type * chore: lint * fix: merge main * fix: resolve errors * chore: notify terminal profile settings * chore: merge main * feat: improve default terminal profile changes * fix: update changes on save
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One-line fix to ensure litellm model list refreshes go through by first clearing the litellm model list cache
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Fixes cache issue in
LiteLLM.tsxby flushing models before refetching.LiteLLM.tsx, added a call tovscode.postMessagewith typeflushRouterModelsbeforerequestRouterModelsto clear the cache.handleRefreshModelsinLiteLLM.tsxto include cache flushing step.This description was created by
for 32d9247. You can customize this summary. It will automatically update as commits are pushed.