-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
61453a6
docs: update contributors list [skip ci]
taylorwilsdon fd5c1fc
add refresh all mcp button & supporting logic
taylorwilsdon f91cc5b
fully working, clean up debug
taylorwilsdon 3b2b5d7
begin cleanup
taylorwilsdon 34d28cb
console debug logging cleanup
taylorwilsdon ef16d37
more logging
taylorwilsdon 9ed7924
Merge pull request #1 from taylorwilsdon/update-contributors
taylorwilsdon d3b0121
Merge branch 'RooCodeInc:main' into main
taylorwilsdon 43e416a
Revert "Update contributors list"
taylorwilsdon e113f6f
Merge pull request #2 from taylorwilsdon/revert-1-update-contributors
taylorwilsdon 8c64d5f
Merge branch 'main' of github.com:taylorwilsdon/Roo-Code into refresh…
taylorwilsdon aeac9e4
cleanup
taylorwilsdon 8724b8d
add missing translations
taylorwilsdon 0d4292c
Merge branch 'RooCodeInc:main' into main
taylorwilsdon 23e39fa
Merge branch 'main' of github.com:taylorwilsdon/Roo-Code into refresh…
taylorwilsdon b3f680e
global and project level i18n strings
taylorwilsdon cdce3b0
refactor: move translations
daniel-lxs efe7363
fix: improve MCP settings buttons layout for responsive design
daniel-lxs c8d16ca
fix: Add missing vscode mock method and execa mock for McpHub tests
daniel-lxs 7cc5305
fix: watch changes on project mcp settings file
daniel-lxs fa8887f
Merge branch 'main' into refresh_mcp
mrubens File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few nitpicks on the internationalization that I can help out with later:
common?global_mcp_servers_activeandproject_mcp_servers_activestrings in case the order is different in any languages. "none" can probably live under common .There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++ the i18n is always a little different project to project, figured there would be a little bit of a learning curve. Happy to expand any coverage as needed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mrubens, just circling back here to clean these up - should have some time after work tonight. I'm thinking todo items are:
global_mcp_servers_activeandproject_mcp_servers_activein place of the generalmcp_servers_activewhere applicableThe pattern I was following was where the existing mcp server related information messages lived ie
"common:info.mcp_server_connected"based on #3865582 but I see there's also the mcp.json in each locale so I'm thinking that is probably the right home? Let me know if that's the correct landing spot more than happy to handle the refac. I can move all the mcp related ones into mcp.json unless you'd prefer otherwise!There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added global and project level + i18n in current location and pushed up, will hold off until I hear otherwise as far as moving them into a different locale file. Looking at the structure, it appears you've got two different approaches:
common.json&tools.jsonas the only optionsaccount.jsonchat.jsoncommon.jsonmcp.jsonetcThe existing i18n in McpHub all pull from the former source so if approved I will refac to place all of those in mcp.json in their relevant webview-ui locale