feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267

taylorwilsdon · 2025-06-02T22:18:44Z

Related GitHub Issue

Closes: #4265
Closes: #4431

Description

This PR introduces MCP server refresh (button & on save) while introducing reliable deletion for MCP server connections in the Roo Code extension. Wasn't sure if the i18n generation is something I should trigger myself or if it runs as a github action / workflow @mrubens sorry just getting up to speed here but if there's manual action there lmk (edit - did fail on missing i18n, went ahead and had gemini take a run at it - alas I only speak enough french and spanish to verify those particular ones 😂 )

Debugging why the refresh wasn't taking in the actual VSCode panel view stumped Opus and spent like $15 before I gave it up and figured it out the old fashioned way. While I don't usually like to mix feat and bugfix, this is a requirement for this to work (and any other UI updates after initialization of the widget, this actually fixes other stuff that would have reflected without restarting the extension now too)

Key points

refreshAllMcpServers command & UI
- Web-view “Refresh MCP Servers” button (McpView.tsx) sends a new "refreshAllMcpServers" message.
- webviewMessageHandler routes the message to McpHub.refreshAllConnections(), which
  - guards against concurrent refresh with isConnecting,
  - reloads both global & project mcp_settings.json,
  - tears down old connections, re-initialises, and notifies the UI,
  - shows user-visible toasts for already refreshing, in progress, and complete.
Deletion view update fix
- notifyWebviewOfServerChanges() now chooses the correct ClineProvider instance before posting, ensuring that the list re-renders immediately after a delete.
Supporting infrastructure
- updateServerConnections() gains manageConnectingState so internal calls (e.g., during refresh) do not erroneously block the UI.
- New i18n strings (common.json, mcp.json).
- Replaced deprecated react-use useEvent with native window.addEventListener to avoid double listeners during hot reloads.

Reviewer focus

Thread-safety around isConnecting flag.
Correct disposal/re-creation of file watchers.
Web-view post-message flow in notifyWebviewOfServerChanges() (fallback logic).
i18n key names / namespace consistency.

Test Procedure

Manual – refresh path
1. Start extension with at least one working MCP server.
2. Add a new entry to mcp_settings.json (global or project).
3. In the UI, click Refresh MCP Servers.
4. ✅ Expect toast: “Refreshing all MCP servers…”, followed by “All MCP servers have been refreshed.”
5. ✅ List now contains the new server without window reload.
6. Trigger button again quickly → toast: “MCP servers are already refreshing.”
Manual – delete path
1. Delete any server via UI action.
2. ✅ List updates immediately; toast: “Deleted MCP server: <name>”.
Regression – existing flows
- Restart, connect, enable/disable, tool toggles – no regressions (actually improved significantly)

Type of Change

Pre-Submission Checklist

Screenshots / Videos

roo_mcp_after.mov

roo_mcp_before.mov

Documentation Updates

No documentation updates are required.
Yes – (If checked, describe or link docs PR)

Additional Notes

The PR purposefully keeps refreshAllConnections() self-contained to minimise surface area; future enhancements (e.g., per-server ping) can layer on top without altering UI contracts.

Get in Touch

Discord: @taylorwilsdon

Important

Introduces MCP server refresh functionality and fixes deletion view update, with infrastructure improvements and i18n updates.

Behavior:
- Adds refreshAllMcpServers command in webviewMessageHandler.ts to refresh MCP servers.
- Implements refreshAllConnections() in McpHub.ts to reload server configurations and notify UI.
- Updates McpView.tsx to include "Refresh MCP Servers" button.
Deletion Fix:
- Fixes notifyWebviewOfServerChanges() to select correct ClineProvider instance for immediate list re-render.
Infrastructure:
- Adds manageConnectingState to updateServerConnections() in McpHub.ts to prevent UI blocking during refresh.
- Replaces useEvent with window.addEventListener in ExtensionStateContext.tsx for message handling.
- Adds i18n strings in common.json and mcp.json for new messages and UI elements.

^{This description was created by}^{for aeac9e4. You can customize this summary. It will automatically update as commits are pushed.}

Update contributors list

Revert "Update contributors list"

…_mcp

mrubens · 2025-06-02T22:58:02Z

src/services/mcp/McpHub.ts

+					t("common:info.mcp_servers_active", {
+						mcpServers: `Global: ${globalServerNames.join(", ") || "none"}`,
+					}),


A few nitpicks on the internationalization that I can help out with later:

I think this would probably be better in another namespace - is there something better suited than common?

Ideally we can also translate "Global", "Project", and "none". I think maybe I would have a global_mcp_servers_active and project_mcp_servers_active strings in case the order is different in any languages. "none" can probably live under common .

++ the i18n is always a little different project to project, figured there would be a little bit of a learning curve. Happy to expand any coverage as needed!

Hey @mrubens, just circling back here to clean these up - should have some time after work tonight. I'm thinking todo items are:

add global_mcp_servers_active and project_mcp_servers_active in place of the general mcp_servers_active where applicable

refac mcp related i18n strings from common.json into mcp.json (clarifying question below)

The pattern I was following was where the existing mcp server related information messages lived ie "common:info.mcp_server_connected" based on #3865582 but I see there's also the mcp.json in each locale so I'm thinking that is probably the right home? Let me know if that's the correct landing spot more than happy to handle the refac. I can move all the mcp related ones into mcp.json unless you'd prefer otherwise!

Added global and project level + i18n in current location and pushed up, will hold off until I hear otherwise as far as moving them into a different locale file. Looking at the structure, it appears you've got two different approaches:

/src/i18n/locales/{locale}/ with common.json & tools.json as the only options

/webview-ui/src/i18n/locales/{locale} with account.json chat.json common.json mcp.json etc

The existing i18n in McpHub all pull from the former source so if approved I will refac to place all of those in mcp.json in their relevant webview-ui locale

taylorwilsdon · 2025-06-02T23:06:14Z

Failing test doesn't appear related to this change so I won't touch it here to avoid complexity

…_mcp

- Add flexWrap to button container to allow wrapping on smaller screens - Change buttons from fixed flex:1 to flex: 1 1 auto with minWidth - Ensures buttons maintain minimum readable width of 120px - Prevents button text from being truncated on narrow viewports

- Added createTextEditorDecorationType to vscode mock in McpHub.test.ts - Created execa mock to handle ESM module import issues - Fixes test failure that was exposed by PR RooCodeInc#4267's module loading changes

daniel-lxs

Thank you @taylorwilsdon!

Looks good to me, it seems that the changes made to McpHub.ts exposed some issues with jest, but the changes were completely unrelated.

I solved the problems with the test to prevent this PR from causing issues when merged.

I also moved the translations and made the MCP buttons responsive since they were overflowing.

taylorwilsdon · 2025-06-06T17:01:06Z

Thank you @taylorwilsdon!

Looks good to me, it seems that the changes made to McpHub.ts exposed some issues with jest, but the changes were completely unrelated.

I solved the problems with the test to prevent this PR from causing issues when merged.

I also moved the translations and made the MCP buttons responsive since they were overflowing.

Awesome, appreciate you! I think this will be a popular one

daniel-lxs · 2025-06-07T14:25:49Z

Made some additional changes to solve #4431

src/__mocks__/execa.js

mrubens

Thank you!

taylorwilsdon and others added 12 commits June 2, 2025 17:42

docs: update contributors list [skip ci]

61453a6

add refresh all mcp button & supporting logic

fd5c1fc

fully working, clean up debug

f91cc5b

begin cleanup

3b2b5d7

console debug logging cleanup

34d28cb

more logging

ef16d37

Merge pull request #1 from taylorwilsdon/update-contributors

9ed7924

Update contributors list

Merge branch 'RooCodeInc:main' into main

d3b0121

Revert "Update contributors list"

43e416a

Merge pull request #2 from taylorwilsdon/revert-1-update-contributors

e113f6f

Revert "Update contributors list"

Merge branch 'main' of github.com:taylorwilsdon/Roo-Code into refresh…

8c64d5f

…_mcp

cleanup

aeac9e4

taylorwilsdon requested review from cte and mrubens as code owners June 2, 2025 22:18

github-project-automation bot added this to Roo Code Roadmap and Roo Code Roadmap Jun 2, 2025

github-project-automation bot moved this to Triage in Roo Code Roadmap Jun 2, 2025

github-project-automation bot moved this to New in Roo Code Roadmap Jun 2, 2025

dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working enhancement New feature or request labels Jun 2, 2025

taylorwilsdon changed the title ~~feat: Refresh MCP Servers~~ feat: Refresh MCP Servers, fix MCP server management UI display Jun 2, 2025

taylorwilsdon changed the title ~~feat: Refresh MCP Servers, fix MCP server management UI display~~ feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view Jun 2, 2025

hannesrudolph moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 2, 2025

add missing translations

8724b8d

mrubens reviewed Jun 2, 2025

View reviewed changes

Merge branch 'RooCodeInc:main' into main

0d4292c

hannesrudolph added the PR - Needs Preliminary Review label Jun 3, 2025

Merge branch 'main' of github.com:taylorwilsdon/Roo-Code into refresh…

23e39fa

…_mcp

taylorwilsdon and others added 3 commits June 4, 2025 10:52

global and project level i18n strings

b3f680e

refactor: move translations

cdce3b0

daniel-lxs requested a review from jr as a code owner June 6, 2025 16:19

fix: Add missing vscode mock method and execa mock for McpHub tests

c8d16ca

- Added createTextEditorDecorationType to vscode mock in McpHub.test.ts - Created execa mock to handle ESM module import issues - Fixes test failure that was exposed by PR RooCodeInc#4267's module loading changes

daniel-lxs approved these changes Jun 6, 2025

View reviewed changes

dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 6, 2025

daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 6, 2025

daniel-lxs added PR - Needs Review and removed PR - Needs Preliminary Review labels Jun 6, 2025

hannesrudolph mentioned this pull request Jun 6, 2025

Removing .roo/mcp.json doesn't unload MCP servers until workspace reload #4431

Closed

fix: watch changes on project mcp settings file

7cc5305

dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 7, 2025

taylorwilsdon requested a review from mrubens June 7, 2025 23:16

Merge branch 'main' into refresh_mcp

fa8887f

mrubens reviewed Jun 8, 2025

View reviewed changes

src/__mocks__/execa.js Show resolved Hide resolved

mrubens approved these changes Jun 8, 2025

View reviewed changes

mrubens merged commit 3f54efc into RooCodeInc:main Jun 8, 2025
8 of 9 checks passed

github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 8, 2025

github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 8, 2025

bantic mentioned this pull request Jun 10, 2025

Sidebar auto-opens when opening new window #4496

Closed

seedlord mentioned this pull request Jun 11, 2025

feat: add toggle functionality for enabling/disabling/reloading all MCP servers #3737

Closed

9 tasks

mrubens mentioned this pull request Jun 11, 2025

Don't grab sidebar focus in the McpHub #4548

Merged

taylorwilsdon mentioned this pull request Jul 13, 2025

feat: hot reload on config changes open-webui/mcpo#197

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267

feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267

Uh oh!

taylorwilsdon commented Jun 2, 2025 •

edited by daniel-lxs

Loading

Uh oh!

mrubens Jun 2, 2025

Uh oh!

taylorwilsdon Jun 2, 2025

Uh oh!

taylorwilsdon Jun 4, 2025

Uh oh!

taylorwilsdon Jun 4, 2025

Uh oh!

taylorwilsdon commented Jun 2, 2025

Uh oh!

daniel-lxs left a comment •

edited

Loading

Uh oh!

taylorwilsdon commented Jun 6, 2025 •

edited

Loading

Uh oh!

daniel-lxs commented Jun 7, 2025

Uh oh!

Uh oh!

mrubens left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267

feat: Add Refresh MCP Servers capability, fix state changes in MCP server management UI view #4267

Uh oh!

Conversation

taylorwilsdon commented Jun 2, 2025 • edited by daniel-lxs Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Related GitHub Issue

Description

Test Procedure

Type of Change

Pre-Submission Checklist

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch

Uh oh!

mrubens Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

taylorwilsdon Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

taylorwilsdon Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

taylorwilsdon Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

taylorwilsdon commented Jun 2, 2025

Uh oh!

daniel-lxs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

taylorwilsdon commented Jun 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daniel-lxs commented Jun 7, 2025

Uh oh!

Uh oh!

mrubens left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

taylorwilsdon commented Jun 2, 2025 •

edited by daniel-lxs

Loading

daniel-lxs left a comment •

edited

Loading

taylorwilsdon commented Jun 6, 2025 •

edited

Loading