Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 11, 2025

These rules are confusing my tests a lot. I think maybe because Roo isn't aware enough of which directory it's currently in when running commands? Going to try rolling them back for now though.


Important

Removes monorepo.md from .roo/rules, eliminating monorepo and testing guidelines.

  • File Removal:
    • Deletes monorepo.md from .roo/rules.
  • Content Removed:
    • Guidelines for working with monorepo using pnpm and turborepo.
    • Instructions for running and creating tests using vitest and jest.

This description was created by Ellipsis for 70ae2cf. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 11, 2025 15:25
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 11, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 11, 2025
@mrubens
Copy link
Collaborator Author

mrubens commented Jun 11, 2025

I should probably look more closely though and try things out without this file to see if it's any better

@daniel-lxs
Copy link
Member

The main issue I noticed is the vitest instructions, it seems like Roo really struggles to use vitest.
Also the instructions suggest the model to rewrite the existing jest tests using vitest, which causes unwanted changes sometimes.

@mrubens
Copy link
Collaborator Author

mrubens commented Jun 11, 2025

The main issue I noticed is the vitest instructions, it seems like Roo really struggles to use vitest. Also the instructions suggest the model to rewrite the existing jest tests using vitest, which causes unwanted changes sometimes.

Yeah, that's what I'm seeing too. Not sure if the issue is more with how the model uses vitest or with these instructions though.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 11, 2025
@mrubens mrubens merged commit ba6490c into main Jun 11, 2025
22 checks passed
@mrubens mrubens deleted the remove_monorepo_rules branch June 11, 2025 19:25
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 11, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants