Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 12, 2025

Reverts #4511

This makes it so I can't select text.

Screen.Recording.2025-06-12.at.12.49.17.PM.mov

Important

Reverts panel focus behavior to allow text selection, removing focusPanel command and related functionality.

  • Revert Focus Panel Behavior:
    • Remove focusPanel command from registerCommands.ts and vscode.ts.
    • Delete focusPanel.ts utility.
    • Remove focusPanelRequest handling in webviewMessageHandler.ts and WebviewMessage.ts.
    • Remove useNonInteractiveClick hook and related usage in App.tsx.
  • Misc:
    • Fix spacing in TelemetryService.ts.

This description was created by Ellipsis for 95f0f8f. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 12, 2025 16:50
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 12, 2025
@mrubens
Copy link
Collaborator Author

mrubens commented Jun 12, 2025

cc: @hassoncs

@mrubens mrubens merged commit 85fd86e into main Jun 12, 2025
12 of 14 checks passed
@mrubens mrubens deleted the revert-4511-fix-missing-icons-popout-view branch June 12, 2025 16:51
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 12, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 12, 2025
@hassoncs
Copy link
Contributor

hassoncs commented Jun 12, 2025

Ack! Thanks for reverting @mrubens, sorry about that bug. I'll look into it

@hassoncs
Copy link
Contributor

@mrubens here's the fix, but no rush! #4598

cte pushed a commit that referenced this pull request Jun 24, 2025
…e visible" (#4592)

Revert "Always focus the panel when clicked to ensure menu buttons are visibl…"

This reverts commit 1b1e5a2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants