Skip to content

Conversation

@hassoncs
Copy link
Contributor

@hassoncs hassoncs commented Jun 12, 2025

Re-apply the fix from #4592, this time with proper detection of all VSCode related input tags!

Test plan:

  • Redid previous testing
  • Explicitly tested that all input boxes now work

2025-06-12 10 29 05
2025-06-12 10 27 56


Important

Re-applies panel focus fix with improved input detection, adding a new command and utility for focusing panels, and updates webview to request focus on non-interactive clicks.

  • Behavior:
    • Re-applies panel focus fix to ensure menu buttons are visible when the panel is clicked.
    • Adds focusPanelRequest message handling in webviewMessageHandler.ts to execute focusPanel command.
    • Implements useAddNonInteractiveClickListener in App.tsx to post focusPanelRequest when non-interactive elements are clicked.
  • Commands:
    • Adds focusPanel command in registerCommands.ts to focus the active panel using focusPanel().
  • Utilities:
    • Introduces focusPanel() in focusPanel.ts to focus either tab or sidebar panels.
  • Misc:
    • Adds focusPanel to commandIds in vscode.ts.
    • Fixes spacing typo in TelemetryService.ts.

This description was created by Ellipsis for 1e80a04. You can customize this summary. It will automatically update as commits are pushed.

hassoncs added 2 commits June 12, 2025 09:58
Enhances the non-interactive click listener by adding support for 'VSCODE-TEXT-AREA' and 'VSCODE-TEXT-FIELD' tags. This ensures that typing in VSCode-specific input elements is not disrupted by unintentional triggers.

Not including these element was causing users not to be able to edit some input boxes on the settings page. This fixes that!
@hassoncs hassoncs requested review from cte, jr and mrubens as code owners June 12, 2025 17:35
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused labels Jun 12, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 12, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 12, 2025
@hannesrudolph hannesrudolph added PR - Needs Preliminary Review and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 12, 2025
Comment on lines +21 to +22
target.tagName !== "VSCODE-TEXT-AREA" &&
target.tagName !== "VSCODE-TEXT-FIELD" &&
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was missing these before which caused the revert

itemType,
itemName,
target,
... (properties || {}),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is unrelated but the linter does it automatically

Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hassoncs, I made some changes to prevent some weird behavior I was seeing with the tab trying to focus again even when it already had the focus.
Also the sidebar doesn't need focus when clicking a non-interactive element since the icons in the toolbar are always visible.

I tested every input field I could find and seems to be working.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 14, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 14, 2025
@mrubens mrubens merged commit e484bff into RooCodeInc:main Jun 17, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 17, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
…re visible" (#4598)

Co-authored-by: Daniel Riccio <[email protected]>
Co-authored-by: Matt Rubens <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants