Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 13, 2025

Got some feedback in Discord that people do have use cases for searching outside of the workspace. This PR changes it to respect the auto-approve checkbox for reading outside of the workspace (defaulted to false) instead of always erroring.


Important

The PR updates searchFilesTool to respect the auto-approve setting for searches outside the workspace, removing previous error handling and updating UI and translations accordingly.

  • Behavior:
    • searchFilesTool in searchFilesTool.ts now respects the auto-approve setting for searches outside the workspace.
    • Removed error handling for searches outside the workspace in searchFilesTool.ts.
  • Tests:
    • Deleted searchFilesTool.spec.ts as it contained tests for the removed error handling.
  • UI:
    • Updated ChatRow.tsx to display different messages based on whether the search is inside or outside the workspace.
    • Updated translation files to remove workspace boundary error messages.

This description was created by Ellipsis for 25d3542. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 13, 2025 22:24
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 13, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 13, 2025
@mrubens mrubens merged commit 10b2fb3 into main Jun 13, 2025
25 checks passed
@mrubens mrubens deleted the search_outside_workspace branch June 13, 2025 22:49
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 13, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 13, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
#4670)

Adjust searching outside of the workspace to respect the auto-approve checkbox
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants